New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for binaries (address #1) #12
Conversation
|
Great! Can we start with |
|
Makes sense :) But while making the adjustments I found an problem. With my current implementation it just happened to work by accident :-) In the case of phpunit, it tries to load the autoload by looking in 3 locations: I'm not even sure this is easy to fix, as there is no way to tell how the executable tries to load files. It might try to use the autoloader, but it might also just try to include files relative from it's own location. One thing that works with the autoloader, is to change the |
6fcfb8f
to
c8aae15
Compare
c8aae15
to
5d5e565
Compare
|
Just updated the PR.
|
|
Found another edge-case yesterday. I'm not sure this is something Fiddler can and should account for, but for my case it's quit annoying :-) I was trying to get phpspec working with our components and fiddler, but they retrieve the autoloader pretty weird:
This would mean (when executed from the component), that it will first get the autoloader from the component. And after that it will load the autoloader from root. When executed from the root it would mean the autoloader wouldn't know about the files from the component, so all tests fail 😄 Only solution I see now, is removing autoloading files from Fiddler all together, but allow for defining specific in the Fiddler.json, for cases where you do need it? Or if that turns out to be to invasive, maybe add an option to fiddler to skip autoloading files? |
fb972c6
to
b6be461
Compare
Adding support for binaries (address #1)
This is a hacked solution, but works :)
Just wanted to open the PR to discuss options.
Our use case is the following:
We use phpunit as a dev-dependency and use the executable provided to run it.
At first I just ran the phpunit binary that gets installed by the root composer. That didn't work, as it then loads 2 autoloaders: the one from the root and the one from the component because we tell in phpunit.dist.xml to load the bootstrap, which loads the autoloader from the component.
Undecided