Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Nov 24, 2011

  1. Fabien Potencier

    [WebProfilerBundle] added missing image for the routing in the web pr…

    …ofiler
    authored November 24, 2011
  2. Fabien Potencier

    merged branch canni/failed_login_event (PR #2678)

    Commits
    -------
    
    09562df Update CHANGELOG for 2.1, describe new auth events
    cf09c2d added authentication success/failure events
    
    Discussion
    ----------
    
    [Security] Implementation of a "failed login" event, replaces: PR #1307
    
    As I have to use this feature I have completed its implementation.
    
    Bugfix: no
    Feature addition: yes
    Symfopny2 tests pass: yes
    Replaces/closes PR: #1307
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2011/11/18 23:57:56 -0800
    
    Usually, this event is used for the wrong reasons (to customize what happens on authentication failure). Can you move your implementation to the AuthenticationProviderManager instead?
    
    see https://github.com/schmittjoh/symfony/blob/master/src/Symfony/Component/Security/Core/Authentication/AuthenticationProviderManager.php#L103
    
    ---------------------------------------------------------------------------
    
    by canni at 2011/11/19 06:00:36 -0800
    
    Good point :) I'll not rewrite yours work, I've cherry-picked yours commits. (BTW you added call to `setEventDispatcher` on `security.authentication.manager` to commit related to some different work ;)
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/11/22 00:12:19 -0800
    
    The new files are missing the LICENSE header. As far as I can see, @schmittjoh fork has a different license from the Symfony one. This needs to be clarified before I can merge this PR.
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2011/11/22 01:53:09 -0800
    
    No biggy, MIT is fine here.
    
    ---------------------------------------------------------------------------
    
    by canni at 2011/11/22 01:57:51 -0800
    
    @fabpot done
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/11/22 02:22:47 -0800
    
    @canni: Can you update the CHANGELOG file (to reference the changes and the BC breaks -- like the move of KernelEvents for instance).
    
    ---------------------------------------------------------------------------
    
    by canni at 2011/11/22 02:40:33 -0800
    
    @fabpot: no problem & done
    
    PS I haven't realized that namespace change of `SecurityEvents` is actually a BC Break, thx for pointing this.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/11/22 03:06:17 -0800
    
    @canni: What about keeping a `SecurityEvents` class in the `Http` namespace that just extends the new one. That way, we don't break BC.
    
    ---------------------------------------------------------------------------
    
    by canni at 2011/11/22 03:53:01 -0800
    
    @fabpot: that will force us to remove `final` keyword form one of classes.
    
    Maybe we can add new, not extending class e.g.: `GeneralSecurityEvents` or `AuthenticationEvents`, that way we dont break BC and dont introduce confusion in naming?
    
    ---------------------------------------------------------------------------
    
    by canni at 2011/11/22 05:53:15 -0800
    
    @fabpot: I've removed the BC break, and squashed schmittjoh commits, to keep things nice and clear.
    authored November 24, 2011
  3. Fabien Potencier

    removed unused use statements

    authored November 24, 2011
  4. Fabien Potencier

    merged 2.0

    authored November 24, 2011
  5. Fabien Potencier

    removed unused use statements

    authored November 24, 2011

Nov 23, 2011

  1. Fabien Potencier

    merged 2.0

    authored November 23, 2011
  2. Fabien Potencier

    merged branch Seldaek/composerfix3 (PR #2704)

    Commits
    -------
    
    ca974f5 Fix doctrine requirement
    a250e3d Update root package versions
    c76487e Fix composer.json files to be stricter
    
    Discussion
    ----------
    
    Fix composer.json files to be stricter
    authored November 23, 2011
  3. Jordi Boggiano

    Fix doctrine requirement

    authored November 23, 2011
  4. Jordi Boggiano

    Update root package versions

    authored November 23, 2011
  5. Jordi Boggiano

    Fix composer.json files to be stricter

    authored November 23, 2011
  6. Fabien Potencier

    merged 2.0

    authored November 23, 2011
  7. Fabien Potencier

    merged branch Seldaek/composerfix2 (PR #2701)

    Commits
    -------
    
    e7215ae Fix composer.json
    
    Discussion
    ----------
    
    Fix composer.json files
    
    >=2.1 does not include the 2.1.0-dev versions, since those are lesser than 2.1.0 stable, so nothing is really working right now.
    authored November 23, 2011
  8. Fabien Potencier

    merged branch Seldaek/composerfix (PR #2700)

    Commits
    -------
    
    a5a8675 Fix requirement name
    
    Discussion
    ----------
    
    Fix requirement name
    authored November 23, 2011
  9. Jordi Boggiano

    Fix composer.json

    authored November 23, 2011
  10. Jordi Boggiano

    Fix requirement name

    authored November 23, 2011
  11. Fabien Potencier

    merged branch lsmith77/travis-ci-master (PR #2699)

    Commits
    -------
    
    3f9a0bf set travis-ci icon to master
    
    Discussion
    ----------
    
    set travis-ci icon to master
    authored November 23, 2011
  12. Lukas Kahwe Smith

    set travis-ci icon to master

    authored November 23, 2011
  13. Fabien Potencier

    fixed bad merge

    authored November 23, 2011
  14. Fabien Potencier

    merged 2.0

    authored November 23, 2011
  15. Fabien Potencier

    merged branch pulzarraider/proxy_ip_fix (PR #2695)

    Commits
    -------
    
    11b6156 updated unittest
    a931e21 get correct client IP from X-forwarded-for header
    
    Discussion
    ----------
    
    [HttpFoundation] Get correct client IP when using trusted proxy (Varnish)
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    Note: This is reopened PR #2686 for 2.0 branch.
    
    If using trusted proxy (Varnish, ...) the client IP must be identified from X-Forwarded-For header. The header has de-facto standard format:
    
    X-Forwarded-For : client1, proxy1, proxy2,
    
    where the value is a comma+space separated list of IP addresses, the left-most being the farthest downstream client, and each successive proxy that passed the request adding the IP address where it received the request from. See: http://en.wikipedia.org/wiki/X-Forwarded-For
    
    Function getClientIp should return only one client IP, not a list of all nonimportant IPs as it's now. Similar example can be seen in Cake framework: http://api.cakephp.org/view_source/request-handler-component/#line-477
    
    There are many ways how to chose the first IP from X-Forwarded-For header. Any other faster and more reliable way is welcome.
    authored November 23, 2011
  16. Fabien Potencier

    merged branch lsmith77/travis-ci (PR #2693)

    Commits
    -------
    
    0e51e32 point the status icon to 2.0
    9d2bd1c tweaked travis configuration
    f68c028 [CI] travis-ci.org integration
    
    Discussion
    ----------
    
    Add travis ci to 2.0
    
    The original PR was send to master and not 2.0, so I cherry picked the two relevant commits.
    Once this PR is merged, I will send another PR to master to set the status icon branch accordingly.
    authored November 23, 2011

Nov 22, 2011

  1. Andrej Hudec

    updated unittest

    authored November 22, 2011
  2. Andrej Hudec

    get correct client IP from X-forwarded-for header

    authored November 22, 2011
  3. Lukas Kahwe Smith

    point the status icon to 2.0

    authored November 22, 2011
  4. Fabien Potencier

    tweaked travis configuration

    authored November 22, 2011 lsmith77 committed November 22, 2011
  5. Pascal Borreli

    [CI] travis-ci.org integration

    authored November 10, 2011 lsmith77 committed November 22, 2011
  6. Fabien Potencier

    merged branch lsmith77/forward_compat (PR #2526)

    Commits
    -------
    
    b6bf018 tweaked error handling for the forward compatibility
    dd606b5 added note about the purpose of this class
    c1426ba added locale handling forward compatibility
    10eed30 added MessageDataCollector forward compatibility
    
    Discussion
    ----------
    
    Forward compat
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #2522
    authored November 22, 2011
  7. Dariusz Górecki

    Update CHANGELOG for 2.1, describe new auth events

    authored November 22, 2011
  8. Johannes

    added authentication success/failure events

    authored July 07, 2011 canni committed November 22, 2011
  9. Fabien Potencier

    fixed a merge problem

    authored November 22, 2011
  10. Hubert LECORCHE

    [Form] added some unit tests

    authored November 22, 2011 fabpot committed November 22, 2011
  11. Fabien Potencier

    merged branch hlecorche/valid-form-w3c (PR #2676)

    Commits
    -------
    
    78e9b2f [Form] Fixed textarea_widget (W3C standards)
    
    Discussion
    ----------
    
    [Form] Fixed textarea_widget (W3C standards)
    
    Textarea widget included the "pattern" attribute but is not valid by W3C standards.
    
    (See PR 2666 - New PR because rebase inside the 2.0 branch)
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/11/18 09:01:41 -0800
    
    @hlecorche: Thanks for your work on this issue. Can you update the unit tests to be sure that this case is covered? If you're not comfortable with this, just tell me and I will do it myself
    
    ---------------------------------------------------------------------------
    
    by hlecorche at 2011/11/19 02:51:06 -0800
    
    @fabpot: I did'nt commited because I am not sure. I changed the "tests/Symfony/Tests/Component/Form/AbstractLayoutTest.php" file :
    
        public function testTextarea()
        {
            $form = $this->factory->createNamed('textarea', 'na&me', 'foo&bar', array(
                'property_path' => 'name',
                'pattern' => 'foo',
            ));
    
            $this->assertWidgetMatchesXpath($form->createView(), array(),
        '/textarea
        [@name="na&me"]
        [not(@pattern)]
        [.="foo&bar"]
        '
            );
        }
    
    Is it correct?
    authored November 22, 2011
  12. Fabien Potencier

    [Form] tweaked an exception message

    authored November 22, 2011
  13. Fabien Potencier

    merged branch canni/throw_exception_on_form_name_circulal_ref (PR #2675)

    Commits
    -------
    
    36cebf0 Fix infinite loop on circullar reference in form factory
    
    Discussion
    ----------
    
    [BugFix][Form]Throw exception on form name circulal ref
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Closes: #2673
    
    When FormType method `getName()` returns the same value as `getParent()` we're asking about trouble, and land into infinite loop.
    authored November 22, 2011
  14. Fabien Potencier

    merged 2.0

    authored November 22, 2011
Something went wrong with that request. Please try again.