New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid potential SQL injection when updating relations with params #1608
Merged
batopa
merged 9 commits into
bedita:3-corylus
from
fquffio:fix/v3/sanitize-relation-params
Jun 6, 2019
Merged
Avoid potential SQL injection when updating relations with params #1608
batopa
merged 9 commits into
bedita:3-corylus
from
fquffio:fix/v3/sanitize-relation-params
Jun 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batopa
reviewed
Jun 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ObjectRelation model too.
batopa
requested changes
Jun 5, 2019
didoda
approved these changes
Jun 6, 2019
batopa
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR fixes a (potentially serious) vulnerability. When saving a relation with parameters, since the encoded JSON was not being properly escaped, it was possible to inject custom SQL by simply adding an apostrophe (
') to one relation parameter.For instance, when linking a Document and an Image together, it would have been possible to give a maliciously-crafted "label" to expose arbitrary data from any table.
This PR fixes this vulnerability by ensuring data is explicitly sanitized before it is used to build queries.
Note: #1462 would have been a safer alternative… if it worked!😄 It turned out to have bad effects since some relations were wiped out and not being updated altogether.