Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Exherbo support #121
paradigm left a comment
I added some comments. Apologies if any come off as pedantic, but I think such pedantry is necessary to keep a code base clean and consistent with multiple contributors. Happily, such items should be quick and easy to resolve. Note I only mentioned the first instance I noticed of some items that occur again elsewhere.
If you feel you have a counter argument to anything I've mentioned, do feel free to bring it up.
Looks like you did not:
This makes sense, as those are both dependent on changes elsewhere, and would result in the code not working in its existing context. Provided we don't forget to make those changes before merging, everything looks good to me. I'll get back to you once the changes needed elsewhere are made at which time we can make the two above mentioned changes, rebase, and merge. Provided nothing comes up that requires rushing an update out, my guess is this will be in 0.7.7 released in about two weeks.