Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exherbo support #121

Closed
wants to merge 14 commits into from

Conversation

@Philantrop
Copy link
Contributor

commented May 31, 2019

These commits add support for fetching Exherbo Linux (https://exherbo.org/). I'm Wulf "Philantrop" Krueger, a core distro developer for Exherbo (https://exherbo.org/developers.html) and would take care of this fetcher as a distro maintainer if you agree.

@paradigm

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

I'd absolutely love for you to take the role of Bedrock's Exherbo maintainer. When I get the chance I'll update the project website indicating so, and work with you to get PR in.

Copy link
Member

left a comment

I added some comments. Apologies if any come off as pedantic, but I think such pedantry is necessary to keep a code base clean and consistent with multiple contributors. Happily, such items should be quick and easy to resolve. Note I only mentioned the first instance I noticed of some items that occur again elsewhere.

If you feel you have a counter argument to anything I've mentioned, do feel free to bring it up.

src/slash-bedrock/share/brl-fetch/distros/exherbo Outdated Show resolved Hide resolved
src/slash-bedrock/share/brl-fetch/distros/exherbo Outdated Show resolved Hide resolved
src/slash-bedrock/share/brl-fetch/distros/exherbo Outdated Show resolved Hide resolved
src/slash-bedrock/share/brl-fetch/distros/exherbo Outdated Show resolved Hide resolved
src/slash-bedrock/share/brl-fetch/distros/exherbo Outdated Show resolved Hide resolved
src/slash-bedrock/share/brl-fetch/distros/exherbo Outdated Show resolved Hide resolved
src/slash-bedrock/share/brl-fetch/distros/exherbo Outdated Show resolved Hide resolved
src/slash-bedrock/share/brl-fetch/distros/exherbo Outdated Show resolved Hide resolved
@Philantrop

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

I hope I've addressed everything. :-)

@paradigm

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Looks like you did not:

  • Change paludis_builddir=/var/paludis to paludis_builddir=/var/tmp/paludis
  • Use the proposed ${cache} system.

This makes sense, as those are both dependent on changes elsewhere, and would result in the code not working in its existing context. Provided we don't forget to make those changes before merging, everything looks good to me. I'll get back to you once the changes needed elsewhere are made at which time we can make the two above mentioned changes, rebase, and merge. Provided nothing comes up that requires rushing an update out, my guess is this will be in 0.7.7 released in about two weeks.

@nift4

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

@Philantrop @paradigm said this PR will be in 0.7.8, not 0.7.7 like said above.

# The number of days any given downloaded file is cached.
expiration = 1


This comment has been minimized.

Copy link
@paradigm

paradigm Aug 27, 2019

Member

I've added a caching solution to master which includes a bedrock.conf setting. There will likely be value in adding caching for other subsystems, such as the upcoming pmm, and so I placed the setting under [miscellaneous] rather than a brl-fetch specific heading.

src/slash-bedrock/libexec/brl-fetch Show resolved Hide resolved

step "Downloading bootstrap software"
wget "${target_mirror:-}"/stages/"${ex_stage}" -O "${bootstrap_dir:-}"/"${ex_stage}"
wget "${target_mirror:-}"/stages/"${ex_checksum}" -O "${bootstrap_dir:-}"/"${ex_checksum}"

This comment has been minimized.

Copy link
@paradigm

paradigm Aug 27, 2019

Member

Master now includes a checksum_download which will conditionally download a file if it's not already cached, which you can use here. See the other back-ends.

@paradigm paradigm force-pushed the bedrocklinux:master branch 2 times, most recently from 82c011b to bdd89f0 Aug 27, 2019
@Philantrop

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

Closed in favour of PR #138

@Philantrop Philantrop closed this Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.