Skip to content

add customisable script path to script config - #738

Closed
Atom1cByte wants to merge 1 commit into
bee-san:masterfrom
Atom1cByte:master
Closed

add customisable script path to script config#738
Atom1cByte wants to merge 1 commit into
bee-san:masterfrom
Atom1cByte:master

Conversation

@Atom1cByte

Copy link
Copy Markdown

I haven't added a command line argument for it, but I was wondering if it would be better to just add a command line argument for the script config path, if that doesn't already exist and have that config just point to the scripts.

@PsypherPunk

Copy link
Copy Markdown
Collaborator

@Atom1cByte, could you rebase off master? There's a recent fix which should resolve those errors and remove some of the noise.

@PsypherPunk PsypherPunk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; a useful addition would be to:

  • extend the fixtures/test_rustscan_scripts.toml example to include the new directory config.
  • add a test to this file to verify that it's being parsed correctly

Otherwise, this is nice.

@bee-san

bee-san commented Mar 4, 2025

Copy link
Copy Markdown
Owner

I am in favour but agree about tests, this is the kinda thing we'd forget to test

@bee-san bee-san closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants