Skip to content

all: simplify boolean expressions #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amrfaissal merged 1 commit into from
Feb 9, 2019
Merged

all: simplify boolean expressions #3523

amrfaissal merged 1 commit into from
Feb 9, 2019

Conversation

@quasilyte
Copy link
Contributor

@quasilyte quasilyte commented Feb 9, 2019

  • !(a == b) => a != b
  • !(a != b) => a == b

Signed-off-by: Iskander Sharipov quasilyte@gmail.com

@quasilyte
all: simplify boolean expressions
67666db 
- !(a == b) => a != b
- !(a != b) => a == b

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
amrfaissal
amrfaissal approved these changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@amrfaissal amrfaissal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@amrfaissal amrfaissal merged commit 3224369 into beego:develop Feb 9, 2019
@DennisMao DennisMao mentioned this pull request Sep 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amrfaissal amrfaissal amrfaissal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quasilyte @amrfaissal