Permalink
Commits on Jun 21, 2017
  1. Changelog for #2605

    sampsyo committed Jun 21, 2017
  2. Merge pull request #2605 from beetbox/fixednone

    Always use specific null values for fixed fields
    sampsyo committed on GitHub Jun 21, 2017
Commits on Jun 20, 2017
  1. Musical key field may be None

    Fixes a `modify` test, of all things.
    sampsyo committed Jun 20, 2017
  2. Explicitly let artpath be missing

    We really want `Album.artpath` to be None sometimes, and this was relying on
    some accidental dbcore behavior before. Now, we explicitly mark the field as
    nullable: it may be a path, or it may be None to indicate that there is no
    art.
    sampsyo committed Jun 20, 2017
  3. Fix some brittle query tests

    These were written to incidentally depend on Nones; the behavior they're
    actually testing doesn't really have anything to say about None-ness.
    sampsyo committed Jun 20, 2017
  4. Always use specific null values for fixed fields

    This came out of an attempt to address the mysterious testing problems from
    PR #2563 and turned into a big old debacle. As it turns out, the problem came
    from calling Item.from_path and getting None for fields that weren't filled
    out by the MediaFile data. Everywhere else, we fill out these fixed attributes
    with the special null value for the field's type, so it's actually pretty
    confusing that these could mysteriously become None. I think it will be saner
    all around if we enforce this universally.
    
    There were two possible fixes: one in __getitem__ to check for missing values
    and one that set all the missing values in the constructor. I opted for the
    former because it has a smaller footprint, but the latter might have slightly
    better performance (depending on the ratio of constructions to lookups).
    sampsyo committed Jun 20, 2017
  5. Version bump: 1.4.6

    sampsyo committed Jun 20, 2017
  6. Add date to changelog

    sampsyo committed Jun 20, 2017
  7. Spruce up changelog for release

    sampsyo committed Jun 20, 2017
Commits on Jun 17, 2017
  1. Fix path in read errors while writing (#2599)

    sampsyo committed Jun 17, 2017
  2. Expand error message for FileTypeError (#2599)

    ...when Mutagen doesn't recognize the type at all.
    sampsyo committed Jun 17, 2017
Commits on Jun 16, 2017
  1. Merge pull request #2598 from beetbox/relativedate

    Relative date queries (continuation of #2418)
    sampsyo committed on GitHub Jun 16, 2017
  2. Changelog for relative dates (#2418, #2598)

    sampsyo committed Jun 16, 2017
  3. Move the relative date docs downward

    It's important to introduce the .. syntax before we get here.
    sampsyo committed Jun 16, 2017
  4. Merge branch 'relativedate'

    euri10 committed Jun 16, 2017
  5. Renamed relative to relative_units

    Changed the return in case of a relative date, by default precision is
    to the second, aka 5
    Removed old 'relative' precision that indeed isn't necessary anymore
    Corrected doc according to current relative date format, no more @
    euri10 committed Jun 16, 2017
  6. Changelog for #2596 (fixes #2595)

    sampsyo committed on GitHub Jun 16, 2017
  7. Merge pull request #2596 from aranc23/metasync-fixes

    do not quote the value in xml, use quoteattr to add quotes as needed
    sampsyo committed on GitHub Jun 16, 2017
  8. Wrap a long line

    sampsyo committed on GitHub Jun 16, 2017
Commits on Jun 15, 2017
  1. Some formatting cleanup for relative dates

    sampsyo committed Jun 15, 2017
  2. More docstring whitespace

    sampsyo committed Jun 15, 2017
  3. Merge branch 'master' into euri10-master

    sampsyo committed Jun 15, 2017
  4. Correct some PEP8 post-docstring whitespace

    To better match #2597 for a cleaner diff.
    sampsyo committed Jun 15, 2017
  5. Slightly clearer layout for #2593, and comments

    sampsyo committed Jun 15, 2017
  6. Changelog for #2593

    sampsyo committed Jun 15, 2017
  7. Merge pull request #2593 from robot3498712/develop

    fix /issues/2592: web: Use Unicode paths to send files on Windows und…
    sampsyo committed Jun 15, 2017
  8. do not quote the value in xml, use quoteattr to add quotes as needed

    Aran Cox committed Jun 15, 2017
  9. fixed failing test - line too long

    robot3498712 committed Jun 15, 2017
  10. fix /issues/2592: web: Use Unicode paths to send files on Windows und…

    …er Python 2
    robot3498712 committed Jun 15, 2017
  11. Corrected some flake8 errors, overindentation and pycharm reformat

    don't seem to play well
    euri10 committed Jun 15, 2017