New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad genres field can break the writing of genre/genres tags #1279

Closed
randybias opened this Issue Jan 29, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@randybias

randybias commented Jan 29, 2015

Steps to reproduce:

[recommend starting with an empty database and single file to import; you will need the 'info' plugin]

  1. beet import
  2. beet modify genres=Electronica
  3. beet info | grep genre
    • You will see something like:
         genre: E
         genres: E; l; e; c; t; r; o; n; i; c; a
  1. beet modify genre="Foo"
  2. beet info | grep genre

At this point modifying either genre or genres will not work for these files. The SQLite database will have the correct information, but "beet write" will always fail to write out the tag.

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Jan 29, 2015

Member

The plural genres is experimental; we should probably remove it, actually. Does everything work if you use the singular genre?

Member

sampsyo commented Jan 29, 2015

The plural genres is experimental; we should probably remove it, actually. Does everything work if you use the singular genre?

@randybias

This comment has been minimized.

Show comment
Hide comment
@randybias

randybias Jan 29, 2015

Yes. It only breaks when genres get modified in that specific manner, which then somehow seems to break genre itself.

randybias commented Jan 29, 2015

Yes. It only breaks when genres get modified in that specific manner, which then somehow seems to break genre itself.

@sampsyo sampsyo added the needinfo label Jan 31, 2015

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Jan 31, 2015

Member

Could we possibly just avoid using the genres field? That represents the progress we're making on #119 but isn't quite ready for use.

Member

sampsyo commented Jan 31, 2015

Could we possibly just avoid using the genres field? That represents the progress we're making on #119 but isn't quite ready for use.

@randybias

This comment has been minimized.

Show comment
Hide comment
@randybias

randybias Jan 31, 2015

I don't have any use for it but maybe someone else does?

randybias commented Jan 31, 2015

I don't have any use for it but maybe someone else does?

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Jan 31, 2015

Member

Let's leave this where it is for now—the feature can be considered "in progress".

Member

sampsyo commented Jan 31, 2015

Let's leave this where it is for now—the feature can be considered "in progress".

@sampsyo sampsyo closed this Jan 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment