Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedart: Respect ignore setting #1632

Closed
jhuldtgren opened this issue Oct 2, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@jhuldtgren
Copy link

commented Oct 2, 2015

if you have the following in your config.yaml

ignore: .AppleDouble ._* *~ .DS_Store

When you run the importer it will ignore files like ._song.mp3 but import song.mp3, however embedart will not honor this and will try to use the bogus file ._album.jpg to embed as the art file instead of using the correct file album.jpg

If you execute beet with verbose logging you'll even see it fail

Sending event:art_set
embedart: Embedding album art into Artist - Album
embedart: not embedding image of unsupported type: image/x-None
embedart: not embedding image of unsupported type: image/x-None
embedart: not embedding image of unsupported type: image/x-None
embedart: not embedding image of unsupported type: image/x-None

@sampsyo sampsyo changed the title embedart does not respect ignore embedart: Respect ignore setting Oct 2, 2015

@sampsyo sampsyo added the feature label Oct 2, 2015

@sampsyo

This comment has been minimized.

Copy link
Member

commented Oct 2, 2015

Seems like a solid addition.

@sampsyo sampsyo added the bitesize label Jan 26, 2016

@ghost

This comment has been minimized.

Copy link

commented Jan 29, 2016

Hey guys, we would like to tackle this issue, if anyone is going to work on this soon let me know so we can look at other issues! We're planning to start working on this on Monday February 1st. Thanks! -Jake

@untitaker

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2016

@BeetsStudentTeam Since the latest update on this issue is from last October I don't think anybody will be working on this anytime soon, so feel free to start!

@regagain

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

This issue is fixed by #3099. It should be fine to close it. 😊

@sampsyo

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

Wahoo; thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.