Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchart: Restore iTunes Store source #2551

Closed
owcz opened this issue May 5, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@owcz
Copy link
Contributor

commented May 5, 2017

fetchart once supported the retrieval of iTunes Store artwork with https://github.com/ocelma/python-itunes, but the package has not been maintained for the last year and was removed from the documentation (#2540) when it began throwing errors (#2371, #1610). Perhaps a py3 compatibility issue?

iTunes is, in my experience, the highest-quality album art provider outside of https://coverartarchive.org. It would be a boon to have it work with fetchart again. Not sure if it's possible or important to resuscitate python-itunes but you might also find inspiration/code in https://greasyfork.org/en/scripts/20771-stig-s-art-grabr

@sampsyo sampsyo added the feature label May 5, 2017

@sampsyo sampsyo changed the title Fetchart: Add iTunes Store fetchart: Restore iTunes Store source May 5, 2017

@Kraymer

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2017

Thanks for the sum-up.

Not sure if it's possible or important to resuscitate python-itunes

I had a look at it and except one trivial URL to fix, the tests pass on python 2.7.
It's then a matter to port ~700 LOC to python3.
From ocelma/python-itunes#9 it seems @ocelma is not interested anymore to maintain the package, so we could fork it in beetbox (under a new name as credentials to take control of the original python-itunes package have been lost).

nathdwek added a commit that referenced this issue Aug 15, 2018

Changelog for #2718
Reverts 49e548b from #2540
Fixes #2371 #2551
@nathdwek

This comment has been minimized.

Copy link
Member

commented Aug 15, 2018

Closed by #2718

@nathdwek nathdwek closed this Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.