Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Conflict between behaviour & documentation of incremental_skipped_later flag #3315
See original discussion here: https://discourse.beets.io/t/importing-skipped-albums-incremental-skipped-later-not-being-observed-properly/815
The documentation states:
However, the boolean condition in importer.py is currently:
The expectation is that on the second import, since the quiet flag is turned off, beets will try to import the albums that were skipped during the first import. However, it just states
Verified that if I add the following to config.yaml, then it works as expected.
I suppose this can be fixed by either changing the documentation or changing the boolean condition in importer.py. To be honest, I'm not entirely sure what should be the expected behaviour given the flag name "incremental_skip_later". It's quite confusing.
Arg! What a mess. This is indeed very confusing and we’ve obviously messed up the docs.
Here's a brief history of where all this came from:
So I think we should fix the docs, not the code. It needs to say the opposite of what it currently says. And hopefully we can make the actual use case more obvious in the process.