Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lyrics: Use MusicBrainz artist aliases if default query is not found #3340

Open
octos opened this issue Aug 3, 2019 · 1 comment

Comments

@octos
Copy link
Contributor

commented Aug 3, 2019

Use case

I just noticed that the Lyrics plugin fails to fetch lyrics to CHVRCHΞS songs because the artist name contains a Greek uppercase Xi (Ξ), whereas musixmatch.com and lyrics.wikia.com URLs are presumably limited to ASCII characters.

lyrics: failed to fetch: http://lyrics.wikia.com/Chvrch%CE%BEs:Forever (404)
lyrics: failed to fetch: https://www.musixmatch.com/lyrics/Chvrch%CE%BEs/Forever (404)

Solution

One solution would be for the Lyrics plugin to cycle through the artist’s MuzicBrainz aliases if it hits a 404 error.

See also

https://discourse.beets.io/t/asciiized-filenames-for-fetching-lyrics/855

@sampsyo sampsyo changed the title ASCIIized filenames for fetching lyrics (MusicBrainz aliases) lyrics: Use MusicBrainz artist aliases if default query is not found Aug 3, 2019

@sampsyo sampsyo added the feature label Aug 3, 2019

@sampsyo

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Sounds good! It's worth noting that the plugin already does a few things like this for normalizing typography, but using the MB aliases would be a good idea too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.