New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable the MusicBrainz data source #400

Open
alastair opened this Issue Sep 29, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@alastair
Copy link

alastair commented Sep 29, 2013

I'd like to perform an series of imports using beets but instead of using the musicbrainz autotagger I'd like to write my own matcher as a plugin.
There is a config option import.autotag, but this disables the tagger completely.

@sampsyo has suggested another config option to handle this, but it might be a little messy to implement, so I'm asking for some feedback.
My current idea would be to put a config option check in beets/autotag/hooks.py, in each of the methods that can be extended in the plugins, e.g.
https://github.com/sampsyo/beets/blob/master/beets/autotag/hooks.py#L534
The alternative would be to move the check higher up to somewhere like https://github.com/sampsyo/beets/blob/master/beets/autotag/match.py#L409, but this might require some larger changes to the plugin system.

The other problem I can see is that there is a significant reliance on musicbrainz track ids, e.g. https://github.com/sampsyo/beets/blob/master/beets/autotag/match.py#L450. Any chance of working around these without a large rewrite?

@sampsyo

This comment has been minimized.

Copy link
Member

sampsyo commented Sep 29, 2013

Yes, I think the first place you mentioned (in hooks.py) is ideal. In short, since beets now supports pluggable metadata sources, the MusicBrainz source is very much like a plugin that can't be disabled. And the hooks.py functions are the place where the MB source is aggregated with the plugin source. (Of course, a longer-term way to solve this would be to turn MB into a real plugin that's enabled by default but can be disabled.)

And the other issue you pointed out is a good one—that deduplication step will behave incorrectly for matches without MBIDs. Maybe a separate ticket is in order?

@sampsyo sampsyo changed the title Lookup and import without using the musicbrainz matcher Disable or de-prioritize the MusicBrainz data source Sep 10, 2017

@sampsyo sampsyo changed the title Disable or de-prioritize the MusicBrainz data source Optionally disable the MusicBrainz data source Sep 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment