Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd the musicbrainz_releasetrackid tag #406
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sampsyo
Oct 8, 2013
Member
Looks great; we should definitely add this.
We can also consider following Picard's lead and changing our internal recording ID name from mb_trackid to mb_recordingid (although this would be a bit of a DB migration headache).
|
Looks great; we should definitely add this. We can also consider following Picard's lead and changing our internal recording ID name from |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mineo
Apr 21, 2014
Contributor
Something that I just thought about because people were talking about duplicates in #mb: if this gets implemented, it would be a good idea to have the duplicates plugin check this tag instead of mb_trackid in https://github.com/sampsyo/beets/blob/master/beetsplug/duplicates.py#L116 because mb_trackid is not really a good indicator for duplicate files.
|
Something that I just thought about because people were talking about duplicates in #mb: if this gets implemented, it would be a good idea to have the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mineo
Oct 7, 2014
Contributor
I'm not sure how up to date the bpd plugin is with compatibility to the real MPD, but the real one will support this tag in 0.19 (http://git.musicpd.org/cgit/master/mpd.git/commit/?id=5525ea45a4e1765db110a8ca5abbc3ca5e66a89a).
|
I'm not sure how up to date the |
pprkut
referenced this issue
Jan 17, 2015
Closed
mbsync: Tolerate MusicBrainz recording ID changes #1234
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rawrmonkeys
Mar 19, 2018
Contributor
What is the status on this? I see that #2690 has some discussion.
Is there anything getting in the way of adding support for the musicbrainz_releasetrackid tag and tossing the possible DB change of mb_trackid -> mb_recordingid into it's own issue?
|
What is the status on this? I see that #2690 has some discussion. Is there anything getting in the way of adding support for the musicbrainz_releasetrackid tag and tossing the possible DB change of mb_trackid -> mb_recordingid into it's own issue? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
sampsyo
Mar 19, 2018
Member
Yep, just adding the recording ID would be totally fine. Any help would be appreciated.
|
Yep, just adding the recording ID would be totally fine. Any help would be appreciated. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
You mean the release track id? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Oops, yes! |
mineo commentedOct 8, 2013
We decided to call it musicbrainz_releasetrackid at the summit (https://wiki.musicbrainz.org/MusicBrainz_Summit/13#Elephant_IDs). The commit adding it to Picard is metabrainz/picard@04c3035 so you can just reuse the tag names for all the different formats.