Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable disambiguator display in importer album overview #845

Open
241n opened this issue Jun 27, 2014 · 7 comments

Comments

Projects
None yet
4 participants
@241n
Copy link

commented Jun 27, 2014

Currently, a tagging source prints some information about the found release in a predetermined layout, for example

URL:
    http://www.discogs.com/Noisia-Spinor-Masada-Lifeless/release/354669
(Similarity: 51.7%) (album, artist, source, tracks) (Discogs, 2xVinyl, 2004, Netherlands, Citrus Recordings)

It would be very useful to be able to customize that layout. In my case, the simple addition of printing the catalog number of the found release would spare me looking at 2+ links per release.

@sampsyo

This comment has been minimized.

Copy link
Member

commented Jun 27, 2014

Sounds reasonable! Specifically, you would be customizing the disambiguation display: that last pair of parentheses.

@sampsyo sampsyo added the feature label Jun 27, 2014

@sampsyo sampsyo changed the title allow customizing the importer album overview Configurable disambiguator display in importer album overview Jun 27, 2014

@PadraicODonoghue

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2014

https://github.com/sampsyo/beets/blob/master/beets/ui/commands.py#L119
Am I right in saying this is where the changes would need to be made?

The we could read in something like this from the config.

import:
    disimbaguation: year country label catalog
@sampsyo

This comment has been minimized.

Copy link
Member

commented Jun 27, 2014

Yes, exactly!

@241n

This comment has been minimized.

Copy link
Author

commented Jun 27, 2014

Perfect! I do love the fast response times around here!

@PadraicODonoghue

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2014

Okay so I've been looking at this and from what I can gather my best bet for implementing a disambiguation string based on a user provided string would be to use Templates and the provided Template class. However since disambig_string() takes an AlbumInfo or TrackInfo object I'd need to provide an evaluate_template() for them like here?

@sampsyo

This comment has been minimized.

Copy link
Member

commented Jul 1, 2014

Yes, something along those lines. It might be a good a time as any to transition those classes, AlbumInfo and TrackInfo, to using dicts instead of a long list of field names—that would make filling templates much easier.

@TimvHerpen

This comment has been minimized.

Copy link

commented Dec 18, 2017

I hope this feature gets added soon, or that the catalog number will be shown when showing the different releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.