New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backed audiotools to replaygain module and updated documentation #1070

Merged
merged 4 commits into from Nov 10, 2014

Conversation

Projects
None yet
3 participants
@frubino
Collaborator

frubino commented Nov 7, 2014

Added a backend that uses http://audiotools.sourceforge.net like discussed and updated the documentation a bit.

I'll add comments later on, but I'd like for people to test the code if possible.

Francesco

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Nov 8, 2014

Member

This looks quite solid! Thanks!

Looks like there are a few lines that are longer than 80 characters (c.f.). I know it's a tiny thing, but would you mind wrapping those?

If anyone has the dependencies in working order, a quick sanity-check on another system would be awesome.

Member

sampsyo commented Nov 8, 2014

This looks quite solid! Thanks!

Looks like there are a few lines that are longer than 80 characters (c.f.). I know it's a tiny thing, but would you mind wrapping those?

If anyone has the dependencies in working order, a quick sanity-check on another system would be awesome.

Show outdated Hide outdated docs/plugins/replaygain.rst Outdated

@sampsyo sampsyo merged commit e4dfd23 into beetbox:master Nov 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request Nov 10, 2014

Merge pull request #1070 from frubino/master
Added backed audiotools to replaygain module and updated documentation

sampsyo added a commit that referenced this pull request Nov 10, 2014

Quiet down logging in #1070
This looks mostly helpful for debugging but redundant with the ordinary
logging.

sampsyo added a commit that referenced this pull request Nov 10, 2014

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Nov 10, 2014

Member

Thanks! I can't test this thoroughly at the moment, but it looks like it's in order. I made a few small changes in logging & style, but otherwise merged as-is.

Member

sampsyo commented Nov 10, 2014

Thanks! I can't test this thoroughly at the moment, but it looks like it's in order. I made a few small changes in logging & style, but otherwise merged as-is.

@frubino

This comment has been minimized.

Show comment
Hide comment
@frubino

frubino Nov 10, 2014

Collaborator

Good, I'll take a moment to comment the code a bit later, let me know if it works.

Collaborator

frubino commented Nov 10, 2014

Good, I'll take a moment to comment the code a bit later, let me know if it works.

@frubino

This comment has been minimized.

Show comment
Hide comment
@frubino

frubino Nov 10, 2014

Collaborator

I pulled your commits, maybe you've got the wrong name in the changelog?

Collaborator

frubino commented Nov 10, 2014

I pulled your commits, maybe you've got the wrong name in the changelog?

sampsyo added a commit that referenced this pull request Nov 10, 2014

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Nov 10, 2014

Member

Oh no; how embarrassing! Sorry. 😳 I must have been looking at the wrong profile page when I typed that.

Member

sampsyo commented Nov 10, 2014

Oh no; how embarrassing! Sorry. 😳 I must have been looking at the wrong profile page when I typed that.

@frubino

This comment has been minimized.

Show comment
Hide comment
@frubino

frubino Nov 10, 2014

Collaborator

No problem at all.

Collaborator

frubino commented Nov 10, 2014

No problem at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment