New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetchart: add fetching artwork from Wikipedia #1194

Merged
merged 2 commits into from Jan 25, 2015

Conversation

Projects
None yet
4 participants
@tomjaspers
Collaborator

tomjaspers commented Jan 3, 2015

Query DBpedia using SPARQL to obtain the filename of the album's cover, as it is used on the relevant Wikipedia article. The direct image url is then obtained using Wikipedia's API.

@Kraymer

This comment has been minimized.

Show comment
Hide comment
@Kraymer

Kraymer Jan 3, 2015

Collaborator

Interesting approach ! Hadn't heard of dbpedia before.

Collaborator

Kraymer commented Jan 3, 2015

Interesting approach ! Hadn't heard of dbpedia before.

@Kraymer

This comment has been minimized.

Show comment
Hide comment
@Kraymer

Kraymer Jan 3, 2015

Collaborator

Looks good, I just fixed buckets tests that made the Travis build failed.
Could you have a look at the flake8 warnings and add an updated version of the plugin doc to your PR?

Collaborator

Kraymer commented Jan 3, 2015

Looks good, I just fixed buckets tests that made the Travis build failed.
Could you have a look at the flake8 warnings and add an updated version of the plugin doc to your PR?

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Jan 3, 2015

Member

Wow, very cool! This is a nifty use of dbpedia.

Thanks, @Kraymer, and I agree: this will be totally ready to merge once flake8 and docs are ready.

Member

sampsyo commented Jan 3, 2015

Wow, very cool! This is a nifty use of dbpedia.

Thanks, @Kraymer, and I agree: this will be totally ready to merge once flake8 and docs are ready.

@brunal

This comment has been minimized.

Show comment
Hide comment
@brunal

brunal Jan 14, 2015

Collaborator

@Kraymer, given a recent refactorisation your work cannot be cleanly merged any more. Could you update it? You simply have to create a class Wikipedia(ArtSource), turn your function into its get method and the constants into its class variables.

Collaborator

brunal commented Jan 14, 2015

@Kraymer, given a recent refactorisation your work cannot be cleanly merged any more. Could you update it? You simply have to create a class Wikipedia(ArtSource), turn your function into its get method and the constants into its class variables.

@Kraymer

This comment has been minimized.

Show comment
Hide comment
@Kraymer

Kraymer Jan 14, 2015

Collaborator

@brunal je crois que tu voulais t'adresser à tomjaspers plutôt non ? ;)

Collaborator

Kraymer commented Jan 14, 2015

@brunal je crois que tu voulais t'adresser à tomjaspers plutôt non ? ;)

@brunal

This comment has been minimized.

Show comment
Hide comment
@brunal

brunal Jan 14, 2015

Collaborator

Right... @tomjaspers could you update that PR to make it mergeable?

Collaborator

brunal commented Jan 14, 2015

Right... @tomjaspers could you update that PR to make it mergeable?

@tomjaspers

This comment has been minimized.

Show comment
Hide comment
@tomjaspers

tomjaspers Jan 15, 2015

Collaborator

@brunal I was waiting until the refactorisation was merged. I'll do an update tomorrow.

Collaborator

tomjaspers commented Jan 15, 2015

@brunal I was waiting until the refactorisation was merged. I'll do an update tomorrow.

@tomjaspers

This comment has been minimized.

Show comment
Hide comment
@tomjaspers

tomjaspers Jan 24, 2015

Collaborator

@sampsyo Is this good to be merged, or need I do something else ?

Collaborator

tomjaspers commented Jan 24, 2015

@sampsyo Is this good to be merged, or need I do something else ?

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Jan 25, 2015

Member

Looks good; thank you, @tomjaspers! I blame the week-long delay here on GitHub, who does not notify me when people add new commits to a pull request. Thanks for commenting, which brought my attention back. Merging now.

Member

sampsyo commented Jan 25, 2015

Looks good; thank you, @tomjaspers! I blame the week-long delay here on GitHub, who does not notify me when people add new commits to a pull request. Thanks for commenting, which brought my attention back. Merging now.

@sampsyo sampsyo merged commit 1a799bb into beetbox:master Jan 25, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request Jan 25, 2015

Merge pull request #1194 from tomjaspers/master
Fetchart: add fetching artwork from Wikipedia
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment