Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
info plugin: Allow custom formatting and human-readable lengths #1737
Work in progress for implementing the feature discussed on #1689, as the workflow proposed by @awesomer would be pretty much aligned with one of my long-term wishlist for my library (ie. a neat way to assist in adding obscure/missing albums to MusicBrainz without the need for extra tools), and hopefully encourage others contributing back to MusicBrainz.
These commits intend to implement the suggested initial changes on the
The command now accepts the standard formatting argument (via
Makes much sense to me! Just in case the raw number of seconds is useful to someone, an argument (
I'd love some feedback on the current work, and also some thoughts on the preferred way for implementing the next steps. My thoughts go along the line of extending the
Great! The format flag is an excellent first step, and something that could be useful in other contexts too—not just for uploading to MusicBrainz.
If it's OK with you, let's merge the format flag now. But I have a suggestion for the time formatting: let's make this the default for all of beets, not just the
Of course, that makes it somewhat more complicated to revert to the old, raw number if you want that for some reason. This, however, is a broader issue also shared by other fields like
Sure, I'd be happy to leave out the time formatting changes out in favor of implementing them later at a wider scope - as a matter of fact, just pushed some commits that remove that functionality. At a first glance, I'd prefer to leave that change to someone more experienced with the types system instead of working on it myself, but if no one steps up I'd be more than willing to give it a try.