Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Selective apply of functions to items #1843
Cool, that helps! Thanks!
If we're going to have a noun in the prompt, though, it should be
Thanks for being with all the terminology bike-shedding! We're definitely getting closer.
On the broader question of what the prompt should look like: let's stick with something simple for now. The plain (colorized) output from
>>> beets.ui.input_options(('yes', 'no', 'select')) [Y]es, No, Select?
The capitals, brackets, and colors help suggest that Y and N are options, that Y is the default, and that you can also choose to "select" without being too verbose.
Short, off-topic rant: Overall, I'm worried about adding too much complexity to what should be a very simple prompt for most uses. The majority of people will just want to say "yes" or "no" to a listing, so giving a long list of options to read seems like a shame. Git is certainly a counterexample, but IMO option overload is one of the reasons git is so unusable.
i changed the prompt to a more common one.
I also added some code to catch a KeyboardInterrupt in pkess/catch_keyboardinterrupt. Are there any contradictions to implement it like this? It would suppress the Backtrace on output and exit in a clean way. I could also add a line to tell the user s.th. like "Abort due to CTRL-C"
Looks good to me after a review, so please do feel free to merge.
If you can, at some point, please add a brief note to the docs for