Mutagen cleanup #2088
Merged
Mutagen cleanup #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lazka : it's failing flake8 in the scrub plugin can you look into that? |
| @@ -1457,6 +1457,7 @@ def delete(self): | |||
| try: | |||
| self.mgfile.delete() | |||
| except NotImplementedError: | |||
| # (Note: This is fixed in mutagen >=1.31) | |||
There was a problem hiding this comment.
can you s/Note/FIXME/ here? , that way we have a marker to revisit later.
No longer needed since we depend on mutagen 1.27
Instead of the individial mutagen format exceptions use the mutagen.MutagenError exception introduced in 1.25. Since 1.33 mutagen will only raise MutagenError for load/save/delete and no longer raise IOError. Translate both errors to UnreadableFileError to support older and newer mutagen versions. Unify error handling in __init__(), save() and delete(). Since it's no longer possible to get an IOError from MediaFile, adjust all callers and tests accordingly. This was tested with mutagen 1.27 and current mutagen master.
|
Fantastic! Thank you, @lazka -- this helps a lot, and I'm thrilled to be able to simplify the exception handling. I'm tempted to require Mutagen 1.31 and remove those two additional workarounds you noted. If that doesn't raise any red flags for you, I'll make those changes. |
Sounds good. Thanks for the review/merge! |
sampsyo
added a commit
that referenced
this pull request
Jun 28, 2016
This lets us remove a few more workarounds that Mutagen itself has addressed already.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.