New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpdupdate: Use `$MPD_HOST` environment variable. #2175

Merged
merged 1 commit into from Aug 26, 2016

Conversation

Projects
None yet
2 participants
@tarruda
Contributor

tarruda commented Aug 26, 2016

This variable is not standardized, but is already used by the mpc which is the official command-line client. It would be nice if beets read it too, to avoid duplicate configuration for mpc users.

@nathdwek

This comment has been minimized.

Show comment
Hide comment
@nathdwek

nathdwek Aug 26, 2016

Member

Much appreciated!
Could you please amend your commit in order to:

  • Link to somewhere supporting the usage of this variable in the commit message (for example http://linux.die.net/man/1/mpc).
  • Similarly to how mpc explains it, explicitly mention in the doc the precedence of the variable.

edit: Sorry for the misclick 🐭

Member

nathdwek commented Aug 26, 2016

Much appreciated!
Could you please amend your commit in order to:

  • Link to somewhere supporting the usage of this variable in the commit message (for example http://linux.die.net/man/1/mpc).
  • Similarly to how mpc explains it, explicitly mention in the doc the precedence of the variable.

edit: Sorry for the misclick 🐭

@nathdwek nathdwek closed this Aug 26, 2016

@nathdwek nathdwek reopened this Aug 26, 2016

mpdupdate: Support `$MPD_HOST` environment variable.
This environment variable is also used by mpc. See
http://linux.die.net/man/1/mpc for details.
@tarruda

This comment has been minimized.

Show comment
Hide comment
@tarruda

tarruda Aug 26, 2016

Contributor

Done

Contributor

tarruda commented Aug 26, 2016

Done

@nathdwek

This comment has been minimized.

Show comment
Hide comment
@nathdwek

nathdwek Aug 26, 2016

Member

Thank you very much!

Member

nathdwek commented Aug 26, 2016

Thank you very much!

@nathdwek nathdwek merged commit c872adf into beetbox:master Aug 26, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nathdwek added a commit that referenced this pull request Aug 26, 2016

nathdwek added a commit that referenced this pull request Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment