Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add bracket argument to aunique #2399
A little background as to why I felt this was needed:
If I have two albums that are disambiguated by
Also, if I do something like
So this change does a few things:
This will close #2397.
Finally, I think adding the brackets to the
And I'm totally fine if this request is considered unnecessary for whatever reason, especially if some of my changes look "ugly".
Aha! Thanks for diagnosing this—you're right that empty brackets look weird and we should dispense with them. And in addition, the new brackets parameter seems useful. I'm all for this.
It would be awesome to have small tests for the new functionality (dropping empty disambiguation strings and changing the brackets) and a changelog entry.