Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add functions needed for ScriptCollection Support in Tomahawk #240

Merged
merged 1 commit into from Apr 3, 2013

Conversation

Projects
None yet
2 participants
Contributor

xhochy commented Apr 1, 2013

Add support for querying a bit more information from the beets web api to support the view of the whole collection in Tomahawk.

  • albums_for_artist does not expand the items as this is not needed by Tomahawk and expanding the items would increase the response time significantly

@xhochy xhochy referenced this pull request in tomahawk-player/tomahawk-resolvers Apr 1, 2013

Merged

[beets] Add ScriptCollection support #42

sampsyo added a commit that referenced this pull request Apr 3, 2013

Merge pull request #240 from xhochy/feature/tomahawk-scriptcollections
Add functions needed for ScriptCollection Support in Tomahawk

@sampsyo sampsyo merged commit 828bee0 into beetbox:master Apr 3, 2013

1 check passed

default The Travis build passed
Details
Owner

sampsyo commented Apr 3, 2013

Awesome; thanks for looking into this!

I changed the API by one small detail: instead of a dedicated /album/artist/... API endpoint, one can now just use the standard query. Also, I'm defaulting to your new "non-expanded" behavior for the albums endpoint; this makes a lot of sense to me. I'm opening a corresponding PR in the tomahawk-resolvers repo.

@xhochy xhochy deleted the xhochy:feature/tomahawk-scriptcollections branch Apr 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment