New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumping time in beets.js #2822

Merged
merged 2 commits into from Feb 26, 2018

Conversation

Projects
None yet
2 participants
@waweic
Contributor

waweic commented Feb 26, 2018

Round was used instead of floor, so the minute counter jumped after each 30 seconds

waweic
Fix jumping time in beets.js
Round was used instead of floor
@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Feb 26, 2018

Member

Awesome; thank you. That was a dumb mistake. Would you mind adding a quick changelog entry about the fix?

Member

sampsyo commented Feb 26, 2018

Awesome; thank you. That was a dumb mistake. Would you mind adding a quick changelog entry about the fix?

@waweic

This comment has been minimized.

Show comment
Hide comment
@waweic

waweic Feb 26, 2018

Contributor

You are welcome, of course. I have never contributed to a changelog before and don't really know how to write an entry. How would you formulate that?

Contributor

waweic commented Feb 26, 2018

You are welcome, of course. I have never contributed to a changelog before and don't really know how to write an entry. How would you formulate that?

@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Feb 26, 2018

Member

Sure! Just add a bullet to the end of the current "Fixes" list at the top of changelog.rst saying, for example:

* :doc:`/plugins/web`: The time display in the web interface would incorrectly jump
  at the 30-second mark of every minute. Now, it correctly changes over at zero
  seconds. :bug:`2822`
Member

sampsyo commented Feb 26, 2018

Sure! Just add a bullet to the end of the current "Fixes" list at the top of changelog.rst saying, for example:

* :doc:`/plugins/web`: The time display in the web interface would incorrectly jump
  at the 30-second mark of every minute. Now, it correctly changes over at zero
  seconds. :bug:`2822`
@waweic

This comment has been minimized.

Show comment
Hide comment
@waweic

waweic Feb 26, 2018

Contributor

Thanks! If you don't mind, I will just take this for the changelog entry.

Contributor

waweic commented Feb 26, 2018

Thanks! If you don't mind, I will just take this for the changelog entry.

waweic
Update changelog.rst
Add the changelog entry
@sampsyo

This comment has been minimized.

Show comment
Hide comment
@sampsyo

sampsyo Feb 26, 2018

Member

Looks great; thank you!

Member

sampsyo commented Feb 26, 2018

Looks great; thank you!

@sampsyo sampsyo merged commit e938ad3 into beetbox:master Feb 26, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@waweic waweic deleted the waweic:patch-1 branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment