Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove `default` arg for `lastgenre --force` flag #3054

Merged
merged 1 commit into from Apr 6, 2019

Conversation

Projects
None yet
3 participants
@discopatrick
Copy link
Member

commented Oct 16, 2018

To fix #2704

@sampsyo

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

Looks right to me! 😃

@discopatrick

This comment has been minimized.

Copy link
Member Author

commented Oct 16, 2018

@sampsyo I marked as WIP because this is not tested! But if you're confident to merge, please go ahead.

@arcresu

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

FWIW I was able to reproduce the original issue and tested this change at it looks like it does the trick.

@sampsyo

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Yay!! Merged.

@sampsyo sampsyo merged commit 9c7a313 into beetbox:master Apr 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request Apr 6, 2019

Merge pull request #3054 from discopatrick/2704-lastgenre-force
WIP: Remove `default` arg for `lastgenre --force` flag

sampsyo added a commit that referenced this pull request Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.