Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep discogs requests below rate limit #3138

Merged
merged 3 commits into from Feb 9, 2019

Conversation

Projects
None yet
2 participants
@puhoy
Copy link
Contributor

puhoy commented Feb 7, 2019

this is should fix issue #3081.

since the discogs_client doesnt expose the rate limit headers (yet) (see discogs/discogs_client#82), i added some code to keep the request rate below 60 requests per minute for logged-in users, or 25 for not logged-in users, as described here: https://www.discogs.com/developers/#page:home,header:home-rate-limiting

@sampsyo
Copy link
Member

sampsyo left a comment

Cool! Thank you for contributing this! I have just a few notes inline.

Would you mind adding a quick note to the changelog about the change?

Show resolved Hide resolved beetsplug/discogs.py Outdated
Show resolved Hide resolved beetsplug/discogs.py Outdated
Show resolved Hide resolved beetsplug/discogs.py Outdated
Show resolved Hide resolved beetsplug/discogs.py

puhoy added some commits Feb 8, 2019

@sampsyo sampsyo merged commit 5ace667 into beetbox:master Feb 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request Feb 9, 2019

Merge pull request #3138 from puhoy/discogs-ratelimit
keep discogs requests below rate limit
@sampsyo

This comment has been minimized.

Copy link
Member

sampsyo commented Feb 9, 2019

Fantastic! Thank you again for your help. Nice work.

@sampsyo sampsyo referenced this pull request Feb 9, 2019

Closed

discogs: Rate limiting #3081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.