Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beets update: dont move album art twice #3189

Merged
merged 2 commits into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@jroitgrund
Copy link
Contributor

commented Mar 27, 2019

In many cases #2419 was being hit not because users had moved the album art, but because:

  • beets moves items in an album
  • this moves the covert art since with_album=True, but doesn't update album.artpath in the DB because store=False
  • beets moves the album itself
  • this moves the cover art again from the old path, which no longer exists

#3030 hides this error in most cases, but without this fix beets will still lose track of your album art, even if it doesn't throw, as evidenced by the test.

note: to fail without the fix, the test needs to add a second item to the album. this is because only the second item move actually moves the album cover, because the album's path is guessed from its first item's path, and the first item is stored after being moved.

@jroitgrund jroitgrund changed the title Dont move album art twice beets update: dont move album art twice Mar 27, 2019

@sampsyo

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Wow; this is incredibly subtle! Thank you for tracking it down—and for the clean, simple fix. This is truly awesome work.

@sampsyo sampsyo merged commit f842551 into beetbox:master Mar 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.