Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the: log a debug only when text is changed #3195

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@arcresu
Copy link
Member

commented Mar 31, 2019

Previously the the plugin would log a debug message when the text didn't get changed by the plugin, whereas I think what was intended was the opposite. With this change the logged messages show the actual transformations made by the plugin.

the: log a debug only when text is changed
Previously the `the` plugin would log a debug message when the text _didn't_ get changed by the plugin, whereas I think what was intended was the opposite. With this change the logged messages show the actual transformations made by the plugin.
@sampsyo

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Indeed; that totally looks wrong! Thanks for the quick fix!!

@sampsyo sampsyo merged commit 0b4293d into beetbox:master Apr 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request Apr 1, 2019

Merge pull request #3195 from arcresu/patch-1
the: log a debug only when text is changed

sampsyo added a commit that referenced this pull request Apr 1, 2019

@arcresu arcresu deleted the arcresu:patch-1 branch Apr 1, 2019

@RollingStar

This comment has been minimized.

Copy link
Contributor

commented on 0b4293d Apr 21, 2019

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.