Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpd: use plugin logger instead of global logger #3196

Merged
merged 2 commits into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@arcresu
Copy link
Member

commented Mar 31, 2019

There was a code comment indicating that there was a plan to use the plugin logger instead of the global one, so this PR makes that change. It means we drop the --debug flag from the bpd command since the logger is now controlled by the normal beet -v verbosity flag. Also fixes up a debug message that was previously printed to stdout, and tweaks the format of the MPD protocol debug messages to make them a little easier to read/interpret. New look:

[...]
bpd: Building directory tree...
[...]
bpd: Finished building directory tree.
bpd: New client connected
bpd: server: OK MPD 0.13.0
bpd: client: command_list_ok_begin
bpd: client: status
bpd: client: currentsong
bpd: client: command_list_end
bpd: server: volume: 10
             repeat: 0
             random: 0
             consume: 0
             playlist: 0
             playlistlength: 0
             xfade: 0
             mixrampdb: 0
             mixrampdelay: nan
bpd: server: state: stop
bpd: server: list_OK
bpd: server: list_OK
bpd: server: OK

@arcresu arcresu force-pushed the arcresu:bpd-log branch from bd26a0e to b4c4f3c Mar 31, 2019

@sampsyo

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Awesome!! Yes, that has been a long-standing issue. 🚀 Thanks for cleaning this up!

@sampsyo sampsyo merged commit b4c4f3c into beetbox:master Apr 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request Apr 1, 2019

Merge pull request #3196 from arcresu/bpd-log
bpd: use plugin logger instead of global logger

sampsyo added a commit that referenced this pull request Apr 1, 2019

@arcresu arcresu deleted the arcresu:bpd-log branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.