Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Support Python 3.8 (fixes #3201) #3202
This PR fixes support for Python 3.8 by conditionally providing a new second argument to
I have added a
Fantastic and quick work; thank you!! No time like the present to start testing on 3.8, I guess.
I suppose we should start enabling new Python versions on Appveyor. (For the casual observer: we use Appveyor to test on Windows.) It's somewhat less urgent because Appveyor usually uncovers Windows-specific problems and Travis uncovers Python version-specific problems. But it certainly can't hurt to have the extra coverage!
Anyway, this is certainly worth merging now—I'll do that and add a real quick changelog entry.