Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.8 (fixes #3201) #3202

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@jackwilsdon
Copy link
Member

commented Mar 31, 2019

This PR fixes support for Python 3.8 by conditionally providing a new second argument to ast.Module.

I have added a py38-test tox environment (and associated -cov and -flake8 environments) and enabled this on Travis, however I couldn't even see Python 3.7 being tested on AppVeyor. Should both 3.7 and 3.8 be enabled on there?

@jackwilsdon jackwilsdon force-pushed the jackwilsdon:fix-3.8 branch from 5fbafb3 to 8df213e Mar 31, 2019

@sampsyo

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Fantastic and quick work; thank you!! No time like the present to start testing on 3.8, I guess. 😃 🚀

I suppose we should start enabling new Python versions on Appveyor. (For the casual observer: we use Appveyor to test on Windows.) It's somewhat less urgent because Appveyor usually uncovers Windows-specific problems and Travis uncovers Python version-specific problems. But it certainly can't hurt to have the extra coverage!

Anyway, this is certainly worth merging now—I'll do that and add a real quick changelog entry.

@sampsyo sampsyo merged commit 8df213e into beetbox:master Apr 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request Apr 1, 2019

sampsyo added a commit that referenced this pull request Apr 1, 2019

@jackwilsdon jackwilsdon deleted the jackwilsdon:fix-3.8 branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.