mpdstats: use currentsong instead of playlist #3207
Conversation
Improved the method to get the path of the current song. Before, the complete playlist was fetched from the server. Now, the command "currentsong" is used for this purpose. This improves performance when a huge playlist is active.
mpdstats: use currentsong instead of playlist
|
Looks right to me! Thank you yet again! More broadly, thank you for your diligent attention lately to a wide variety of dangling issues, especially surrounding MPD & BPD. I've sent you an invitation to the @beetbox org, which should let you merge things yourself in the future if you like. But of course, requesting a review from others on the project is always welcome. 😃 While I'm here encouraging your continued participation, I'll also draw your attention to my recent call for "core team" members, in case that appeals to you: |
|
Thanks! I can't promise that I'll always be active (I'm familiar with the time demands of an academic life), but I'm a long-time user of beets and I appreciate everything you do to make it a fun and inviting community to be part of so I'm sure I'll stick around :) I fully understand that a mature project like this needs at least as much focus on maintenance as on new development and I'm happy to help out wherever I can. I picked the MPD stuff as a way in just because I think it's neat how a protocol that's simple enough to keep in your head can support such a diversity of workflows. That does seem to be a core part of the beets philosophy more generally. |
This is a copy of #2754, rebased and with the additional small change required to the test. Ive also tested it using bpd (with the changes from my
bpd-idlebranch) and it appears to be working well.Closes #2754, closes #2752