Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpdstats: use currentsong instead of playlist #3207

Merged
merged 3 commits into from Apr 6, 2019

Conversation

Projects
None yet
3 participants
@arcresu
Copy link
Member

commented Apr 6, 2019

This is a copy of #2754, rebased and with the additional small change required to the test. Ive also tested it using bpd (with the changes from my bpd-idle branch) and it appears to be working well.

Closes #2754, closes #2752

ray66 and others added some commits Dec 5, 2017

mpdstats: use currentsong instead of playlist
Improved the method to get the path of the current song. Before, the complete playlist was fetched from the server. Now, the command "currentsong" is used for this purpose. This improves performance when a huge playlist is active.

@sampsyo sampsyo merged commit f35eda7 into beetbox:master Apr 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request Apr 6, 2019

Merge pull request #3207 from arcresu/mpd-currentsong
mpdstats: use currentsong instead of playlist
@sampsyo

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Looks right to me! Thank you yet again!

More broadly, thank you for your diligent attention lately to a wide variety of dangling issues, especially surrounding MPD & BPD. I've sent you an invitation to the @beetbox org, which should let you merge things yourself in the future if you like. But of course, requesting a review from others on the project is always welcome. 😃

While I'm here encouraging your continued participation, I'll also draw your attention to my recent call for "core team" members, in case that appeals to you:
https://discourse.beets.io/t/forming-a-beets-core-team/639/6

@arcresu

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2019

Thanks! I can't promise that I'll always be active (I'm familiar with the time demands of an academic life), but I'm a long-time user of beets and I appreciate everything you do to make it a fun and inviting community to be part of so I'm sure I'll stick around :)

I fully understand that a mature project like this needs at least as much focus on maintenance as on new development and I'm happy to help out wherever I can. I picked the MPD stuff as a way in just because I think it's neat how a protocol that's simple enough to keep in your head can support such a diversity of workflows. That does seem to be a core part of the beets philosophy more generally.

@arcresu arcresu deleted the arcresu:mpd-currentsong branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.