Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch OSError in prune_dirs helper #3209

Merged
merged 2 commits into from Apr 7, 2019

Conversation

Projects
None yet
3 participants
@arcresu
Copy link
Member

commented Apr 7, 2019

Since fnmatch_all can raise OSErrors, and we were already silently giving up in prune_dirs on some of these exception, just do more of the same. Closes #1996.

It seems that this solution was agreed on in the issue but nobody went ahead and implemented it. I haven't made any attempt to test this but it looks sensible.

/cc @jackwilsdon

Catch OSError in prune_dirs
Since `fnmatch_all` can raise `OSError`s, and we were already silently
giving up in `prune_dirs` on some of these exception, just do more of
the same.

@arcresu arcresu added the bug label Apr 7, 2019

@sampsyo

sampsyo approved these changes Apr 7, 2019

Copy link
Member

left a comment

Nice! This looks right to me.

@arcresu arcresu merged commit bb16136 into beetbox:master Apr 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arcresu arcresu deleted the arcresu:prune_dirs-except branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.