Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImageMagick Detection #3269

Merged
merged 1 commit into from May 17, 2019

Conversation

Projects
None yet
3 participants
@fortes
Copy link
Member

commented May 17, 2019

The return statement was at the wrong indent level, so we never checked for the legacy convert executable. I ran into this with the 1.4.8 upgrade, getting warnings since convert no longer gets detected.

@ababyduck looks like you were last in this code, this look OK to you?

Fix ImageMagick Detection
The `return` statement was at the wrong indent level, so we never checked for the legacy `convert` executable

@fortes fortes requested review from sampsyo and removed request for sampsyo May 17, 2019

@ababyduck

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

Yikes, good catch!

The mistake I made in testing this was using WSL as a "legacy" environment. Even though I had Ubuntu running an older ImageMagick package, WSL apparently falls back to magick on the Windows path on the first iteration, when I thought it was simply the next iteration in get_im_version() trying convert.

@fortes fortes merged commit 8591ef4 into master May 17, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fortes fortes deleted the fix-imagemagick-detection branch May 17, 2019

@sampsyo

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Thanks!! I've added a changelog entry.

sampsyo added a commit that referenced this pull request May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.