Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pathlib dependency in tests conditional #3275

Merged
merged 1 commit into from May 30, 2019

Conversation

Projects
None yet
2 participants
@arcresu
Copy link
Member

commented May 30, 2019

We already do this in the optional dependency section so this shouldn't cause any problems. It's only used by the thumbnails plugin.

I noticed that Debian was carrying a patch to remove this line since they install beets with Python 3 only and don't have a Py3 package for pathlib.

Make pathlib dependency in tests conditional
We already do this in the optional dependency section so this shouldn't cause any problems. It's only used by the `thumbnails` plugin.

@sampsyo sampsyo merged commit ece5726 into master May 30, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

sampsyo added a commit that referenced this pull request May 30, 2019

Merge pull request #3275 from beetbox/arcresu-patch-1
Make pathlib dependency in tests conditional

sampsyo added a commit that referenced this pull request May 30, 2019

@sampsyo

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Good call; thanks! I added a quick note to the changelog so the Debian people (and anyone else who's doing a similar thing) know they can remove that patch.

@arcresu arcresu deleted the arcresu-patch-1 branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.