Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue 450: Expand templates in art_filename config option #69

Merged
merged 5 commits into from Dec 5, 2012

Conversation

@jizz
Copy link
Contributor

jizz commented Dec 4, 2012

No description provided.

jizz added 2 commits Dec 4, 2012
Fix for Issue 450: Expand templates in art_filename config option
Fix for Issue 450: Expand templates in art_filename config option
@sampsyo
Copy link
Member

sampsyo commented Dec 4, 2012

Thanks!! This is a great feature and a straightforward implementation.

Looking at the test results on Travis, it looks like there are some places remaining that set Library.art_filename to a string instead of a Template object. I'm guessing that this may just be the default constructor for Library, in which case we can just change that. But we could also consider changing art_destination to accept either a string or a Template as the art_filename. Does that fix make sense?

jizz added 3 commits Dec 5, 2012
art_filename now acceptable as a string or a Template
sampsyo added a commit that referenced this pull request Dec 5, 2012
Fix for Issue 450: Expand templates in art_filename config option
@sampsyo sampsyo merged commit c50289d into beetbox:master Dec 5, 2012
1 check passed
1 check passed
default The Travis build passed
Details
sampsyo added a commit that referenced this pull request Dec 5, 2012
@sampsyo
Copy link
Member

sampsyo commented Dec 5, 2012

Awesome! Thanks again for your effort on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.