Skip to content
This repository has been archived by the owner. It is now read-only.

Fix bug in Bool.js, change default for JSCleaner #566

Merged
merged 2 commits into from Jun 11, 2017

Conversation

@abonie
Copy link
Contributor

@abonie abonie commented Jun 9, 2017

Bug in bool comparisons caused bool/float comparisons to return float.

Default behaviour of assertCodeExecution was to capitalize lowercase
occurences of "true" and "false" in output, which seems to serve no
purpose, but silence the above mentioned bug, and cause tests like
assertCodeExecution("print('true')") to fail.

Also very minor changes to ModuleFunctionTestCase including fixing
misspelled method name.

Bug in bool comparisons caused bool/float comparisons to return float.

Default behaviour of assertCodeExecution was to capitalize lowercase
occurences of "true" and "false" in output, which seems to serve no
purpose, but silence the above mentioned bug, and cause tests like
`assertCodeExecution("print('true')")` to fail.

Also very minor changes to ModuleFunctionTestCase including fixing
misspelled method name.
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Good catch! 🐟

@freakboy3742 freakboy3742 merged commit 9ebacd1 into beeware:master Jun 11, 2017
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants