Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json decoding #586

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
2 participants
@abonie
Copy link
Contributor

commented Jul 4, 2017

Basic features of Python's JSONDecoder implemented with JavaScript's JSON.parse.

@abonie abonie force-pushed the abonie:json_decoding branch 4 times, most recently from 6c73e26 to 1b8721b Jul 10, 2017

@abonie abonie changed the title [WIP] Json decoding Json decoding Jul 10, 2017

@abonie abonie force-pushed the abonie:json_decoding branch from 1b8721b to 6fed7c8 Jul 11, 2017

@freakboy3742

This comment has been minimized.

Copy link
Member

commented Jul 15, 2017

Looks like there's a merge required here as a result of the test_json naming change. If you can sort that out, I'll push the button.

Basic json decoding
Implementation of core json decoding features using JavaScript's
JSON.parse. Some of Python's JSONDecoder features cannot be reasonably
implemented this way.

Also json tests have been divided into separate files.

@abonie abonie force-pushed the abonie:json_decoding branch from 6fed7c8 to de75e9b Jul 16, 2017

@abonie

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2017

I think it is ready, but CI did not rerun tests.

@freakboy3742 freakboy3742 merged commit 23587da into beeware:master Jul 21, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.