Skip to content
This repository has been archived by the owner. It is now read-only.

Split WITH_CLEANUP into WITH_CLEANUP_START/FINISH #620

Merged
merged 1 commit into from Aug 9, 2017

Conversation

@abonie
Copy link
Contributor

@abonie abonie commented Aug 8, 2017

Opcode 81 - WITH_CLEANUP is replaced in Python 3.5+ by pair of opcodes:
81 - WITH_CLEANUP_START and 82 - WITH_CLEANUP_FINISH

}
// Assuming Python 3.5
var ret = this.pop()
var exc = this.pop()

Copy link
Member

@phildini phildini Aug 9, 2017

I don't see how your code is failing this check, so I think this is safe to ignore while we still work out bugs in beekeeper.

Copy link
Member

@freakboy3742 freakboy3742 Aug 9, 2017

Hrm... Yeah - not sure what's going on here, because the Beefore check passed...

}
// Assuming Python 3.5
var ret = this.pop()
var exc = this.pop()

Copy link
Member

@phildini phildini Aug 9, 2017

See above

Opcode 81 - WITH_CLEANUP is replaced in Python 3.5+ by pair of opcodes:
81 - WITH_CLEANUP_START and 82 - WITH_CLEANUP_FINISH
this.push('silenced')
}
} else {
// Assuming Python 3.5
Copy link
Member

@phildini phildini Aug 9, 2017

Will this code work for 3.5+ or just 3.5?

Copy link
Member

@freakboy3742 freakboy3742 Aug 9, 2017

Depends on when/if they change the opcode. It looks like it's the same for 3.6 (except for the format change - but that's a marshalling issue, not an opcode issue.)

@freakboy3742 freakboy3742 merged commit c684ed5 into beeware:master Aug 9, 2017
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants