Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split WITH_CLEANUP into WITH_CLEANUP_START/FINISH #620

Merged
merged 1 commit into from Aug 9, 2017

Conversation

Projects
None yet
4 participants
@abonie
Copy link
Contributor

commented Aug 8, 2017

Opcode 81 - WITH_CLEANUP is replaced in Python 3.5+ by pair of opcodes:
81 - WITH_CLEANUP_START and 82 - WITH_CLEANUP_FINISH

}
// Assuming Python 3.5
var ret = this.pop()
var exc = this.pop()

This comment has been minimized.

This comment has been minimized.

Copy link
@phildini

phildini Aug 9, 2017

Member

I don't see how your code is failing this check, so I think this is safe to ignore while we still work out bugs in beekeeper.

This comment has been minimized.

Copy link
@freakboy3742

freakboy3742 Aug 9, 2017

Member

Hrm... Yeah - not sure what's going on here, because the Beefore check passed...

}
// Assuming Python 3.5
var ret = this.pop()
var exc = this.pop()

This comment has been minimized.

This comment has been minimized.

Copy link
@phildini

phildini Aug 9, 2017

Member

See above

Split WITH_CLEANUP into WITH_CLEANUP_START/FINISH
Opcode 81 - WITH_CLEANUP is replaced in Python 3.5+ by pair of opcodes:
81 - WITH_CLEANUP_START and 82 - WITH_CLEANUP_FINISH

@abonie abonie force-pushed the abonie:with_cleanup_python35 branch from 8130663 to 8df71f1 Aug 8, 2017

this.push('silenced')
}
} else {
// Assuming Python 3.5

This comment has been minimized.

Copy link
@phildini

phildini Aug 9, 2017

Member

Will this code work for 3.5+ or just 3.5?

This comment has been minimized.

Copy link
@freakboy3742

freakboy3742 Aug 9, 2017

Member

Depends on when/if they change the opcode. It looks like it's the same for 3.6 (except for the format change - but that's a marshalling issue, not an opcode issue.)

@freakboy3742 freakboy3742 merged commit c684ed5 into beeware:master Aug 9, 2017

3 checks passed

beekeeper:0/beefore:eslint JavaScript lint checks passed.
Details
beekeeper:0/beefore:pycodestyle Python lint checks passed.
Details
beekeeper:1/smoke-test Smoke build (Python 3.4) passed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.