Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #59 #60

Merged
merged 5 commits into from May 24, 2017
Merged

Fix issue #59 #60

merged 5 commits into from May 24, 2017

Conversation

@Dayof
Copy link
Contributor

@Dayof Dayof commented May 20, 2017

No description provided.

@phildini
Copy link
Member

@phildini phildini commented May 22, 2017

I recognize the test coverage on cricket could be much better, and so this is not a requirement, but if you could add a test or two to prove that the t.join does the right thing, that would be fantastic, and probably increase confidence in merging.

@Dayof
Copy link
Contributor Author

@Dayof Dayof commented May 22, 2017

Ok, thanks for the advice, I'll add this test ! :)

@Dayof
Copy link
Contributor Author

@Dayof Dayof commented May 24, 2017

@phildini I made a test coverage and a video running this test, but you can check by yourself! If something goes wrong, please give me a feedback !! :D

Video link : https://youtu.be/ChvOcVj8trE

@phildini phildini merged commit e5456b7 into beeware:master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants