Skip to content
This repository has been archived by the owner. It is now read-only.

fix Method repr() #837

Merged
merged 27 commits into from Jun 15, 2018
Merged

fix Method repr() #837

merged 27 commits into from Jun 15, 2018

Conversation

@patiences
Copy link
Contributor

@patiences patiences commented Jun 11, 2018

While debugging I came across lines like:

- Comparator: <bound method null.__eq__ of test>

Kept me on the wrong trail for a bit. Turns out org.python.types.Type objects on org.python.types.Methods don't have a __name__ registered. This change uses org.python.types.Type's repr method, resulting in logs like:

- Comparator: <bound method <class 'str'>.__eq__ of test>
AmirYalamov and others added 26 commits Jun 1, 2018
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
…-get-bool

Changed Bool construction to use getBool instead
Use python requires to require Python 3.4
@eliasdorneles
Copy link
Collaborator

@eliasdorneles eliasdorneles commented Jun 13, 2018

Any idea why compilation failed in the CI?

@patiences
Copy link
Contributor Author

@patiences patiences commented Jun 13, 2018

@eliasdorneles Ah, yes -- those failures have since been fixed in #836. I'm not sure how to retrigger the build?

@eliasdorneles
Copy link
Collaborator

@eliasdorneles eliasdorneles commented Jun 13, 2018

@patiences gotcha! So, if you synchronize the branch of this PR with master (either with merge or rebase), it will incorporate those changes and trigger a new build.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

👍

@freakboy3742 freakboy3742 merged commit aa4e0ff into beeware:master Jun 15, 2018
5 checks passed
@patiences patiences deleted the fix-method-repr branch Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants