Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom exceptions test cases #847

Closed
wants to merge 14 commits into from

Conversation

Projects
None yet
1 participant
@BPYap
Copy link
Contributor

commented Jun 25, 2018

Initially this PR includes attempts to support importing custom exceptions via ast parsing method. However, there are far more things and bugs to be resolved using this approach and the code get messier and messier. Then I saw PR #844 which is also solving the same problem (issue #255) but the approach is far more elegant and clean. Hence I revert all my previous commits (except the test cases).

**I'm using the same branch from my fork to show my progress and keep it as record for GSOC. :)

@BPYap

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2018

Closed as #844 is currently handling this in much more elegant and comprehensive fashion.

@BPYap BPYap closed this Aug 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.