Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Set default LANG to en_US.UTF-8 #22

Merged
merged 1 commit into from Feb 11, 2014

Conversation

Projects
None yet
2 participants
Contributor

jsl commented Feb 11, 2014

Sets en_US.UTF-8 as a default in the buildpack following the pattern used by the Heroku-supported Ruby and Python buildpacks. Essentially, configure LANG default for the build of ghc itself, and in the profile which creates the default context for the running application.

This commit changes the previous approach of using /bin/release for setting configuration variables. According to the accepted answer for this SO question, and based on the supported Ruby and Python buildpacks, we should be doing this through the profile.d script that is sourced by Heroku.

References:

Set default LANG to en_US.UTF-8
Sets en_US.UTF-8 following the pattern used by the Ruby and Python
buildpacks. Essentially, configure LANG default for the build, and
in the profile which creates the default context for the running
application.

References:

* Python buildpack language encoding:  https://github.com/heroku/heroku-buildpack-python/blob/566f7f4555dcde26252a0db01f6bd28f6bb00494/bin/compile#L84
* Ruby buildpack language encoding: https://github.com/heroku/heroku-buildpack-ruby/blob/2eb97fcbf5e369800596ba6b070fde0ef17c59e9/lib/language_pack/ruby.rb#L60
Owner

begriffs commented Feb 11, 2014

Superb!

begriffs added a commit that referenced this pull request Feb 11, 2014

@begriffs begriffs merged commit 5f59e48 into begriffs:master Feb 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment