New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and fix regex bug #6

Merged
merged 1 commit into from Aug 12, 2015

Conversation

Projects
None yet
3 participants
@narthur157
Contributor

narthur157 commented Aug 4, 2015

Forgot about this bug I fixed locally a while ago, adding it to this commit and responded to Joel's comments on the patch PR here.

old PR: #5

@narthur157 narthur157 referenced this pull request Aug 4, 2015

Closed

Update README.md #5

@@ -3,7 +3,7 @@ import text from './text';
import module from 'module';
// Finds all '{{> partialName }}' in the template
let findPartial = /{{>\s?([^\s]+)\s?}}/gi;
let findPartial = /{{>\s?([^\s]+?)\s?}}/gi;

This comment has been minimized.

@mrjoelkemp

mrjoelkemp Aug 4, 2015

What's an example of why this is necessary?

@mrjoelkemp

mrjoelkemp Aug 4, 2015

What's an example of why this is necessary?

This comment has been minimized.

@mrjoelkemp

mrjoelkemp Aug 4, 2015

The change, that is

@mrjoelkemp

mrjoelkemp Aug 4, 2015

The change, that is

This comment has been minimized.

@mrjoelkemp

mrjoelkemp Aug 4, 2015

Oh this is a bug fix. We typically link to the actual issue in the commit message or PR body.

@mrjoelkemp

mrjoelkemp Aug 4, 2015

Oh this is a bug fix. We typically link to the actual issue in the commit message or PR body.

This comment has been minimized.

@narthur157

narthur157 Aug 4, 2015

Contributor

Yeah, pretty obscure, but this is why https://regex101.com/r/qP6qJ9/4

@narthur157

narthur157 Aug 4, 2015

Contributor

Yeah, pretty obscure, but this is why https://regex101.com/r/qP6qJ9/4

This comment has been minimized.

@Aintaer

This comment has been minimized.

Show comment
Hide comment
@Aintaer

Aintaer Aug 12, 2015

Contributor

🆒

Contributor

Aintaer commented Aug 12, 2015

🆒

Aintaer added a commit that referenced this pull request Aug 12, 2015

Merge pull request #6 from narthur157/master
Update README and fix regex bug

@Aintaer Aintaer merged commit 01a627a into behance:master Aug 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment