Skip to content
Browse files

For rebroadcastMessages(), the lowest seqno cannot be 0, as a retrans…

…mission of seqno 0 will always fails ! The reason is that all seqnos start at 1, both in NAKACK and UNICAST/UNICAST2.
  • Loading branch information...
1 parent a693387 commit f3ca90c47bddb9e245dbf42b561da2ee0f5873be @belaban committed
Showing with 3 additions and 1 deletion.
  1. +3 −1 src/org/jgroups/protocols/pbcast/NAKACK.java
View
4 src/org/jgroups/protocols/pbcast/NAKACK.java
@@ -1082,7 +1082,9 @@ private void rebroadcastMessages() {
if(my_entry == null)
continue;
their_high=their_entry.getHighest();
- my_high=my_entry.getHighest();
+
+ // cannot ask for 0 to be retransmitted because the first seqno in NAKACK and UNICAST(2) is always 1 !
+ my_high=Math.max(1, my_entry.getHighest());
if(their_high > my_high) {
if(log.isTraceEnabled())
log.trace("sending XMIT request to " + sender + " for messages " + my_high + " - " + their_high);

0 comments on commit f3ca90c

Please sign in to comment.
Something went wrong with that request. Please try again.