From 614eff2bcf7b2f670e0ed6484014853fc9af8f2a Mon Sep 17 00:00:00 2001 From: yangyangtiantianlonglong Date: Thu, 27 Oct 2022 17:17:55 +0800 Subject: [PATCH] Potential null pointer reference Reviewed-by: Shane Lontis Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19429) --- test/ectest.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/ectest.c b/test/ectest.c index 8e62cf01e6e6b5..c0337e1c9531a2 100644 --- a/test/ectest.c +++ b/test/ectest.c @@ -2724,6 +2724,13 @@ static int custom_params_test(int id) if (!TEST_ptr(ctx = BN_CTX_new())) return 0; + BN_CTX_start(ctx); + if (!TEST_ptr(p = BN_CTX_get(ctx)) + || !TEST_ptr(a = BN_CTX_get(ctx)) + || !TEST_ptr(b = BN_CTX_get(ctx)) + || !TEST_ptr(k = BN_CTX_get(ctx))) + goto err; + if (!TEST_ptr(group = EC_GROUP_new_by_curve_name(nid))) goto err; @@ -2735,13 +2742,6 @@ static int custom_params_test(int id) } #endif - BN_CTX_start(ctx); - if (!TEST_ptr(p = BN_CTX_get(ctx)) - || !TEST_ptr(a = BN_CTX_get(ctx)) - || !TEST_ptr(b = BN_CTX_get(ctx)) - || !TEST_ptr(k = BN_CTX_get(ctx))) - goto err; - /* expected byte length of encoded points */ bsize = (EC_GROUP_get_degree(group) + 7) / 8; bsize = 1 + 2 * bsize; /* UNCOMPRESSED_POINT format */