Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower improvements #80

Merged
merged 19 commits into from Oct 12, 2015
Merged

Conversation

brousalis
Copy link
Contributor

Adds a dist folder for bower
Using gulp for the build process
Fixed an issue with the dropdown and $apply collision

@@ -3,6 +3,8 @@

=background-svg($file-name, $size...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 glad this worked

@DLavin23
Copy link
Contributor

lgtm 🎲

// A hack for non-Ruby projects to fake the templates namespace (which lives in a gem)
gulp.task('js-hack', function() {
var stream = source('templates.js');
stream.end("(function() { angular.module('templates', []); }).call(this);");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't encourage calling this a hack as a name for a task. How about js-template-cache or some such

@ajself
Copy link
Contributor

ajself commented Oct 12, 2015

Do these template files have to end in .ngt any more?

@brousalis
Copy link
Contributor Author

Going to keep them as .ngt instead of .html to still support the angular-html2js gem.

brousalis added a commit that referenced this pull request Oct 12, 2015
@brousalis brousalis merged commit 02d63cc into bellycard:master Oct 12, 2015
@brousalis brousalis deleted the bower_improvements branch July 22, 2016 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants