Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i-bem: mod change event is emitted even beforeSetMod handler prevents changing #546

Merged
merged 1 commit into from
Jun 7, 2014
Merged

i-bem: mod change event is emitted even beforeSetMod handler prevents changing #546

merged 1 commit into from
Jun 7, 2014

Conversation

dfilatov
Copy link
Member

@dfilatov dfilatov commented Jun 6, 2014

cc @narqo

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4ee9dc4 on issues/544@v2 into 86aca64 on v2.

@narqo
Copy link
Member

narqo commented Jun 6, 2014

🆒

dfilatov added a commit that referenced this pull request Jun 7, 2014
@dfilatov
Merge pull request #546 from /issues/544@v2
58b5381 
i-bem: mod change event is emitted even `beforeSetMod` handler prevents changing
@dfilatov dfilatov merged commit 58b5381 into v2 Jun 7, 2014
@dfilatov dfilatov deleted the issues/544@v2 branch June 7, 2014 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfilatov @coveralls @narqo