New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update configure project #39
update configure project #39
Conversation
@@ -24,4 +24,4 @@ exports.getTechs = function() { | |||
|
|||
}; | |||
|
|||
exports.defaultTechs = ['css', 'browser.js', 'bemhtml']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
почему?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
потому что bem/bem-core#459 исправлю
@tadatuta готовлю правки, надеюсь после понимания будет больше |
@tadatuta основная задача которую я хочу решить этим PR исключить дополнительные вопросы, которые возникают у новичка когда он видит варнинг. что бы действительно можно было просто начать знакомство с БЭМ на project-stub все должно работать и создавать дополнительные вопросы. |
можешь разбить их на отдельные смысловые куски? так и обсуждать проще и вливать. заранее скажу, что я не готов вливать переименование desktop.bundles -> bundles, т.к. хочется, чтобы было консистентно с другими проектами, где мы используем разделение по платформам. размышления о том, как быть с конфигом уровней есть тут: bem/bem-components#320 |
$ bem server
01:17:00.603 - info: bem 0.7.9
01:17:00.609 - info: Project root is 'c:\Users\Ilya\lab\workspace\bem-project-stub'
01:17:00.720 - info: Graph:
== root
all
build
libs
libs\bem-pr
libs\bem-core
libs\bem-components
desktop.blocks*
libs
libs\bem-pr
libs\bem-core
libs\bem-components
desktop.bundles*
libs
libs\bem-pr
libs\bem-core
libs\bem-components
desktop.blocks*
libs
libs\bem-pr
libs\bem-core
libs\bem-components
01:17:00.725 - info: Server is listening on port 8080. Point your browser to http://localhost:8080/
01:17:05.173 - info: [i] Going to build 'desktop.bundles*' [1]
01:17:05.186 - info: [t] isValid() time for "libs\bem-pr" [1]: 6ms
01:17:05.186 - info: [*] make 'libs\bem-pr' [1]
01:17:05.190 - info: [t] isValid() time for "libs\bem-core" [1]: 6ms
01:17:05.191 - info: [*] make 'libs\bem-core' [1]
01:17:05.193 - info: [t] isValid() time for "libs\bem-components" [1]: 10ms
01:17:05.194 - info: [*] make 'libs\bem-components' [1]
01:17:09.103 - info: Installing dependencies for libs\bem-pr library (npm install)
01:17:11.904 - info: Installing dependencies for libs\bem-core library (npm install)
01:17:12.324 - info: Installing dependencies for libs\bem-components library (npm install)
01:17:30.212 - info: [t] Build time for "libs\bem-pr" [1]: 25033ms
01:17:30.406 - info: [t] Build time for "libs\bem-core" [1]: 25223ms
01:17:32.915 - info: [t] Build time for "libs\bem-components" [1]: 27732ms
01:17:32.917 - info: [t] isValid() time for "libs" [1]: 0ms
01:17:32.917 - info: [*] make 'libs' [1]
01:17:32.918 - info: [t] Build time for "libs" [1]: 1ms
01:17:33.167 - info: [i] Going to build 'desktop.bundles\index*' [2]
01:17:33.206 - info: [t] isValid() time for "libs\bem-pr" [2]: 38ms
01:17:33.210 - info: [t] isValid() time for "libs\bem-core" [2]: 42ms
01:17:33.214 - info: [t] isValid() time for "libs\bem-components" [2]: 45ms
01:17:33.215 - info: [t] isValid() time for "libs" [2]: 0ms
01:17:33.215 - info: [*] make 'libs' [2]
01:17:33.216 - info: [t] Build time for "libs" [2]: 1ms
01:17:33.347 - info: [i] Going to build 'desktop.bundles\index' [3]
01:17:33.387 - info: [t] isValid() time for "libs\bem-pr" [3]: 38ms
01:17:33.388 - info: [t] isValid() time for "libs\bem-core" [3]: 39ms
01:17:33.390 - info: [t] isValid() time for "libs\bem-components" [3]: 40ms
01:17:33.391 - info: [t] isValid() time for "libs" [3]: 0ms
01:17:33.391 - info: [*] make 'libs' [3]
01:17:33.391 - info: [t] Build time for "libs" [3]: 0ms
01:17:33.426 - info: [t] isValid() time for "desktop.bundles\index\index.bemdecl.js" [3]: 2ms
01:17:33.426 - info: [*] make 'desktop.bundles\index\index.bemdecl.js' [3]
01:17:33.441 - info: [t] Build time for "desktop.bundles\index\index.bemdecl.js" [3]: 16ms
01:17:33.442 - info: [t] isValid() time for "desktop.bundles\index\index.deps.js" [3]: 1ms
01:17:33.442 - info: [*] make 'desktop.bundles\index\index.deps.js' [3]
01:17:34.612 - info: [t] Build time for "desktop.bundles\index\index.deps.js" [3]: 1171ms
01:17:34.614 - info: [t] isValid() time for "desktop.bundles\index\index.bemhtml" [3]: 0ms
01:17:34.615 - info: [*] make 'desktop.bundles\index\index.bemhtml' [3]
01:17:34.615 - info: [t] isValid() time for "desktop.bundles\index\index.browser.js+bemhtml" [3]: 1ms
01:17:34.615 - info: [*] make 'desktop.bundles\index\index.browser.js+bemhtml' [3]
01:17:34.615 - info: [t] isValid() time for "desktop.bundles\index\index.css" [3]: 1ms
01:17:34.616 - info: [*] make 'desktop.bundles\index\index.css' [3]
01:17:34.616 - info: [t] isValid() time for "desktop.bundles\index\index.ie.css" [3]: 2ms
01:17:34.617 - info: [*] make 'desktop.bundles\index\index.ie.css' [3]
01:17:34.641 - info: [t] Build time for "desktop.bundles\index\index.ie.css" [3]: 27ms
01:17:34.647 - info: [t] Build time for "desktop.bundles\index\index.css" [3]: 33ms
01:17:34.651 - info: [t] isValid() time for "desktop.bundles\index\_index.css" [3]: 2ms
01:17:34.652 - info: [*] make 'desktop.bundles\index\_index.css' [3]
01:17:34.656 - info: [t] isValid() time for "desktop.bundles\index\_index.ie.css" [3]: 6ms
01:17:34.657 - info: [*] make 'desktop.bundles\index\_index.ie.css' [3]
01:17:35.410 - info: [t] Build time for "desktop.bundles\index\_index.css" [3]:
761ms
01:17:35.482 - info: [t] Build time for "desktop.bundles\index\_index.ie.css" [3]: 832ms
01:17:35.589 - info: [t] Build time for "desktop.bundles\index\index.browser.js+bemhtml" [3]: 975ms
01:17:35.591 - info: [t] isValid() time for "desktop.bundles\index\_index.js" [3]: 1ms
01:17:35.591 - info: [*] make 'desktop.bundles\index\_index.js' [3]
01:17:36.104 - info: [t] Build time for "desktop.bundles\index\_index.js" [3]: 514ms
01:17:36.141 - info: [t] Build time for "desktop.bundles\index\index.bemhtml" [3]: 1527ms
01:17:36.144 - info: [t] isValid() time for "desktop.bundles\index\_index.bemhtml.js" [3]: 2ms
01:17:36.144 - info: [*] make 'desktop.bundles\index\_index.bemhtml.js' [3]
01:17:36.152 - info: [t] isValid() time for "desktop.bundles\index\index.html" [3]: 4ms
01:17:36.152 - info: [*] make 'desktop.bundles\index\index.html' [3]
01:17:36.168 - info: [t] Build time for "desktop.bundles\index\index.html" [3]:
20ms
01:17:36.529 - info: [t] Build time for "desktop.bundles\index\_index.bemhtml.js" [3]: 387ms
01:17:36.531 - info: [t] Build total for "desktop.bundles\index": 3195ms
01:17:36.562 - info: [i] Going to build 'desktop.bundles\index\_index.css' [4]
01:17:36.622 - info: [t] isValid() time for "libs\bem-core" [4]: 59ms
01:17:36.702 - info: [t] isValid() time for "libs\bem-components" [4]: 139ms
01:17:36.859 - info: [i] Going to build 'desktop.bundles\index\_index.js' [5]
01:17:36.895 - info: [t] isValid() time for "libs\bem-core" [5]: 36ms
01:17:36.898 - info: [t] isValid() time for "libs\bem-pr" [4]: 335ms
01:17:36.900 - info: [t] isValid() time for "libs" [4]: 1ms
01:17:36.903 - info: [*] make 'libs' [4]
01:17:36.904 - info: [t] Build time for "libs" [4]: 5ms
01:17:36.951 - info: [t] isValid() time for "libs\bem-components" [5]: 91ms
01:17:36.954 - info: [t] isValid() time for "desktop.bundles\index\index.bemdecl.js" [4]: 2ms
01:17:36.955 - info: [t] isValid() time for "desktop.bundles\index\index.deps.js" [4]: 0ms
01:17:36.956 - info: [*] make 'desktop.bundles\index\index.deps.js' [4]
01:17:37.059 - info: [t] isValid() time for "libs\bem-pr" [5]: 160ms
01:17:37.060 - info: [t] isValid() time for "libs" [5]: 0ms
01:17:37.060 - info: [*] make 'libs' [5]
01:17:37.060 - info: [t] Build time for "libs" [5]: 0ms
01:17:37.105 - info: [t] isValid() time for "desktop.bundles\index\index.bemdecl.js" [5]: 2ms
01:17:37.110 - info: [t] Build time for "desktop.bundles\index\index.deps.js" [4]: 155ms
01:17:37.111 - info: [t] isValid() time for "desktop.bundles\index\index.deps.js" [5]: 0ms
01:17:37.112 - info: [*] make 'desktop.bundles\index\index.deps.js' [5]
01:17:37.112 - info: [t] isValid() time for "desktop.bundles\index\index.css" [4]: 1ms
01:17:37.113 - info: [*] make 'desktop.bundles\index\index.css' [4]
01:17:37.132 - info: [t] Build time for "desktop.bundles\index\index.deps.js" [5]: 21ms
01:17:37.134 - info: [t] isValid() time for "desktop.bundles\index\index.browser.js+bemhtml" [5]: 0ms
01:17:37.134 - info: [*] make 'desktop.bundles\index\index.browser.js+bemhtml' [5]
01:17:37.137 - info: [t] Build time for "desktop.bundles\index\index.css" [4]: 26ms
01:17:37.139 - info: [t] isValid() time for "desktop.bundles\index\_index.css" [4]: 1ms
01:17:37.140 - info: [t] Build total for "desktop.bundles\index\_index.css": 581ms
01:17:37.679 - info: [t] Build time for "desktop.bundles\index\index.browser.js+bemhtml" [5]: 546ms
01:17:37.680 - info: [t] isValid() time for "desktop.bundles\index\_index.js" [5]: 0ms
01:17:37.681 - info: [t] Build total for "desktop.bundles\index\_index.js": 823ms |
согласен, вернул
хорошо, прочитаю размышления и разобью на куски с учетом #38 |
@tadatuta скажи возможно не включая |
@ilyar завел про это bem/bem-components#336 |
убрал bem-pr, подождем решение с варнингами в bem/bem-components#336 обновил только настройку уровней но она не будет работать без #41 // cc @tadatuta |
|
||
PRJ_ROOT = environ.PRJ_ROOT, | ||
PRJ_TECHS = join(PRJ_ROOT, '.bem/techs'), | ||
PRJ_TECHS = PATH.resolve(__dirname, '../techs/'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
чем этот вариант лучше, чем было (PRJ_ROOT = environ.PRJ_ROOT
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
соглашусь, лучше PRJ_ROOT = environ.PRJ_ROOT
least warnings and as a consequence least questions.