Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update configure project #39

Merged
merged 1 commit into from Apr 6, 2014
Merged

update configure project #39

merged 1 commit into from Apr 6, 2014

Conversation

ilyar
Copy link
Contributor

@ilyar ilyar commented Mar 20, 2014

least warnings and as a consequence least questions.

$ bem server
15:28:44.876 - info: bem 0.7.9
15:28:44.880 - info: Project root is 'c:\Users\Ilya\lab\workspace\my-bem-project'
15:28:44.957 - info: Graph:
== root
 all
   build
     libs
       libs\bem-pr
       libs\bem-core
       libs\bem-components
     blocks*
       libs
         libs\bem-pr
         libs\bem-core
         libs\bem-components
     bundles*
       libs
         libs\bem-pr
         libs\bem-core
         libs\bem-components
       blocks*
         libs
           libs\bem-pr
           libs\bem-core
           libs\bem-components

15:28:44.960 - info: Server is listening on port 8080. Point your browser to http://localhost:8080/
15:28:52.122 - info: [i] Going to build 'bundles*' [1]
15:28:52.127 - info: [t] isValid() time for "libs\bem-pr" [1]: 2ms
15:28:52.128 - info: [*] make 'libs\bem-pr' [1]
15:28:52.129 - info: [t] isValid() time for "libs\bem-core" [1]: 3ms
15:28:52.130 - info: [*] make 'libs\bem-core' [1]
15:28:52.131 - info: [t] isValid() time for "libs\bem-components" [1]: 5ms
15:28:52.132 - info: [*] make 'libs\bem-components' [1]
15:28:56.527 - info: Installing dependencies for libs\bem-pr library (npm install)
15:28:59.338 - info: Installing dependencies for libs\bem-components library (npm install)
15:29:00.313 - info: Installing dependencies for libs\bem-core library (npm install)
15:29:12.986 - info: [t] Build time for "libs\bem-pr" [1]: 20861ms
15:29:17.413 - info: [t] Build time for "libs\bem-core" [1]: 25287ms
15:29:20.922 - info: [t] Build time for "libs\bem-components" [1]: 28796ms
15:29:20.923 - info: [t] isValid() time for "libs" [1]: 0ms
15:29:20.923 - info: [*] make 'libs' [1]
15:29:20.924 - info: [t] Build time for "libs" [1]: 1ms
15:29:21.145 - info: [i] Going to build 'bundles\index*' [2]
15:29:21.187 - info: [t] isValid() time for "libs\bem-pr" [2]: 41ms
15:29:21.190 - info: [t] isValid() time for "libs\bem-core" [2]: 43ms
15:29:21.497 - info: [t] isValid() time for "libs\bem-components" [2]: 350ms
15:29:21.497 - info: [t] isValid() time for "libs" [2]: 0ms
15:29:21.498 - info: [*] make 'libs' [2]
15:29:21.498 - info: [t] Build time for "libs" [2]: 1ms
15:29:21.585 - warn: Level at c:\Users\Ilya\lab\workspace\my-bem-project\bundles\index\blocks is not a directory
15:29:21.652 - info: [i] Going to build 'bundles\index\index.html' [3]
15:29:21.697 - info: [t] isValid() time for "libs\bem-core" [3]: 43ms
15:29:21.699 - info: [t] isValid() time for "libs\bem-components" [3]: 45ms
15:29:21.944 - info: [t] isValid() time for "libs\bem-pr" [3]: 291ms
15:29:21.945 - info: [t] isValid() time for "libs" [3]: 0ms
15:29:21.946 - info: [*] make 'libs' [3]
15:29:21.947 - info: [t] Build time for "libs" [3]: 1ms
15:29:21.984 - info: [t] isValid() time for "bundles\index\index.bemdecl.js" [3]: 2ms
15:29:21.984 - info: [*] make 'bundles\index\index.bemdecl.js' [3]
15:29:22.006 - info: [t] Build time for "bundles\index\index.bemdecl.js" [3]: 24ms
15:29:22.007 - info: [t] isValid() time for "bundles\index\index.deps.js" [3]: 0ms
15:29:22.008 - info: [*] make 'bundles\index\index.deps.js' [3]
15:29:23.297 - info: [t] Build time for "bundles\index\index.deps.js" [3]: 1290ms
15:29:23.299 - info: [t] isValid() time for "bundles\index\index.bemhtml" [3]: 0ms
15:29:23.299 - info: [*] make 'bundles\index\index.bemhtml' [3]
15:29:23.756 - warn: Level at c:\Users\Ilya\lab\workspace\my-bem-project\bundles\index\blocks is not a directory
15:29:24.264 - info: [t] Build time for "bundles\index\index.bemhtml" [3]: 965ms
15:29:24.268 - info: [t] isValid() time for "bundles\index\index.html" [3]: 2ms
15:29:24.268 - info: [*] make 'bundles\index\index.html' [3]
15:29:24.284 - info: [t] Build time for "bundles\index\index.html" [3]: 18ms
15:29:24.285 - info: [t] Build total for "bundles\index\index.html": 2635ms
15:29:24.319 - info: [i] Going to build 'bundles\index\_index.css' [4]
15:29:24.362 - info: [t] isValid() time for "libs\bem-pr" [4]: 42ms
15:29:24.364 - info: [t] isValid() time for "libs\bem-components" [4]: 43ms
15:29:24.619 - info: [i] Going to build 'bundles\index\_index.js' [5]
15:29:24.653 - info: [t] isValid() time for "libs\bem-pr" [5]: 33ms
15:29:24.656 - info: [t] isValid() time for "libs\bem-components" [5]: 36ms
15:29:24.674 - info: [t] isValid() time for "libs\bem-core" [4]: 354ms
15:29:24.675 - info: [t] isValid() time for "libs" [4]: 0ms
15:29:24.675 - info: [*] make 'libs' [4]
15:29:24.676 - info: [t] Build time for "libs" [4]: 1ms
15:29:24.735 - info: [t] isValid() time for "bundles\index\index.bemdecl.js" [4]: 2ms
15:29:24.736 - info: [t] isValid() time for "bundles\index\index.deps.js" [4]: 0ms
15:29:24.736 - info: [*] make 'bundles\index\index.deps.js' [4]
15:29:24.827 - info: [t] isValid() time for "libs\bem-core" [5]: 152ms
15:29:24.827 - info: [t] isValid() time for "libs" [5]: 0ms
15:29:24.828 - info: [*] make 'libs' [5]
15:29:24.828 - info: [t] Build time for "libs" [5]: 1ms
15:29:24.876 - info: [t] isValid() time for "bundles\index\index.bemdecl.js" [5]: 3ms
15:29:24.879 - info: [t] Build time for "bundles\index\index.deps.js" [4]: 143ms
15:29:24.880 - info: [t] isValid() time for "bundles\index\index.deps.js" [5]: 0ms
15:29:24.881 - info: [*] make 'bundles\index\index.deps.js' [5]
15:29:24.881 - info: [t] isValid() time for "bundles\index\index.css" [4]: 1ms
15:29:24.881 - info: [*] make 'bundles\index\index.css' [4]
15:29:24.890 - info: [t] Build time for "bundles\index\index.deps.js" [5]: 10ms
15:29:24.890 - info: [t] isValid() time for "bundles\index\index.browser.js+bemhtml" [5]: 0ms
15:29:24.891 - info: [*] make 'bundles\index\index.browser.js+bemhtml' [5]
15:29:24.920 - info: [t] Build time for "bundles\index\index.css" [4]: 40ms
15:29:24.922 - info: [t] isValid() time for "bundles\index\_index.css" [4]: 1ms
15:29:24.923 - info: [*] make 'bundles\index\_index.css' [4]
15:29:24.927 - info: [t] Build time for "bundles\index\index.browser.js+bemhtml" [5]: 36ms
15:29:24.928 - info: [t] isValid() time for "bundles\index\_index.js" [5]: 1ms
15:29:24.929 - info: [*] make 'bundles\index\_index.js' [5]
15:29:25.483 - info: [t] Build time for "bundles\index\_index.css" [4]: 562ms
15:29:25.484 - info: [t] Build total for "bundles\index\_index.css": 1169ms
15:29:25.531 - info: [t] Build time for "bundles\index\_index.js" [5]: 604ms
15:29:25.533 - info: [t] Build total for "bundles\index\_index.js": 917ms

@@ -24,4 +24,4 @@ exports.getTechs = function() {

};

exports.defaultTechs = ['css', 'browser.js', 'bemhtml'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

почему?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

потому что bem/bem-core#459 исправлю

@tadatuta
Copy link
Member

@ilyar Илья, я часть изменений не понимаю, а часть собирался сделать в рамках #38 (там еще есть что улучшить).

@ilyar
Copy link
Contributor Author

ilyar commented Mar 21, 2014

@tadatuta готовлю правки, надеюсь после понимания будет больше

@ilyar
Copy link
Contributor Author

ilyar commented Mar 21, 2014

@tadatuta основная задача которую я хочу решить этим PR исключить дополнительные вопросы, которые возникают у новичка когда он видит варнинг.

что бы действительно можно было просто начать знакомство с БЭМ на project-stub все должно работать и создавать дополнительные вопросы.

@tadatuta
Copy link
Member

можешь разбить их на отдельные смысловые куски? так и обсуждать проще и вливать.

заранее скажу, что я не готов вливать переименование desktop.bundles -> bundles, т.к. хочется, чтобы было консистентно с другими проектами, где мы используем разделение по платформам.

размышления о том, как быть с конфигом уровней есть тут: bem/bem-components#320

@ilyar
Copy link
Contributor Author

ilyar commented Mar 21, 2014

$ bem server
01:17:00.603 - info: bem 0.7.9
01:17:00.609 - info: Project root is 'c:\Users\Ilya\lab\workspace\bem-project-stub'
01:17:00.720 - info: Graph:
== root
 all
   build
     libs
       libs\bem-pr
       libs\bem-core
       libs\bem-components
     desktop.blocks*
       libs
         libs\bem-pr
         libs\bem-core
         libs\bem-components
     desktop.bundles*
       libs
         libs\bem-pr
         libs\bem-core
         libs\bem-components
       desktop.blocks*
         libs
           libs\bem-pr
           libs\bem-core
           libs\bem-components

01:17:00.725 - info: Server is listening on port 8080. Point your browser to http://localhost:8080/
01:17:05.173 - info: [i] Going to build 'desktop.bundles*' [1]
01:17:05.186 - info: [t] isValid() time for "libs\bem-pr" [1]: 6ms
01:17:05.186 - info: [*] make 'libs\bem-pr' [1]
01:17:05.190 - info: [t] isValid() time for "libs\bem-core" [1]: 6ms
01:17:05.191 - info: [*] make 'libs\bem-core' [1]
01:17:05.193 - info: [t] isValid() time for "libs\bem-components" [1]: 10ms
01:17:05.194 - info: [*] make 'libs\bem-components' [1]
01:17:09.103 - info: Installing dependencies for libs\bem-pr library (npm install)
01:17:11.904 - info: Installing dependencies for libs\bem-core library (npm install)
01:17:12.324 - info: Installing dependencies for libs\bem-components library (npm install)
01:17:30.212 - info: [t] Build time for "libs\bem-pr" [1]: 25033ms
01:17:30.406 - info: [t] Build time for "libs\bem-core" [1]: 25223ms
01:17:32.915 - info: [t] Build time for "libs\bem-components" [1]: 27732ms
01:17:32.917 - info: [t] isValid() time for "libs" [1]: 0ms
01:17:32.917 - info: [*] make 'libs' [1]
01:17:32.918 - info: [t] Build time for "libs" [1]: 1ms
01:17:33.167 - info: [i] Going to build 'desktop.bundles\index*' [2]
01:17:33.206 - info: [t] isValid() time for "libs\bem-pr" [2]: 38ms
01:17:33.210 - info: [t] isValid() time for "libs\bem-core" [2]: 42ms
01:17:33.214 - info: [t] isValid() time for "libs\bem-components" [2]: 45ms
01:17:33.215 - info: [t] isValid() time for "libs" [2]: 0ms
01:17:33.215 - info: [*] make 'libs' [2]
01:17:33.216 - info: [t] Build time for "libs" [2]: 1ms
01:17:33.347 - info: [i] Going to build 'desktop.bundles\index' [3]
01:17:33.387 - info: [t] isValid() time for "libs\bem-pr" [3]: 38ms
01:17:33.388 - info: [t] isValid() time for "libs\bem-core" [3]: 39ms
01:17:33.390 - info: [t] isValid() time for "libs\bem-components" [3]: 40ms
01:17:33.391 - info: [t] isValid() time for "libs" [3]: 0ms
01:17:33.391 - info: [*] make 'libs' [3]
01:17:33.391 - info: [t] Build time for "libs" [3]: 0ms
01:17:33.426 - info: [t] isValid() time for "desktop.bundles\index\index.bemdecl.js" [3]: 2ms
01:17:33.426 - info: [*] make 'desktop.bundles\index\index.bemdecl.js' [3]
01:17:33.441 - info: [t] Build time for "desktop.bundles\index\index.bemdecl.js" [3]: 16ms
01:17:33.442 - info: [t] isValid() time for "desktop.bundles\index\index.deps.js" [3]: 1ms
01:17:33.442 - info: [*] make 'desktop.bundles\index\index.deps.js' [3]
01:17:34.612 - info: [t] Build time for "desktop.bundles\index\index.deps.js" [3]: 1171ms
01:17:34.614 - info: [t] isValid() time for "desktop.bundles\index\index.bemhtml" [3]: 0ms
01:17:34.615 - info: [*] make 'desktop.bundles\index\index.bemhtml' [3]
01:17:34.615 - info: [t] isValid() time for "desktop.bundles\index\index.browser.js+bemhtml" [3]: 1ms
01:17:34.615 - info: [*] make 'desktop.bundles\index\index.browser.js+bemhtml' [3]
01:17:34.615 - info: [t] isValid() time for "desktop.bundles\index\index.css" [3]: 1ms
01:17:34.616 - info: [*] make 'desktop.bundles\index\index.css' [3]
01:17:34.616 - info: [t] isValid() time for "desktop.bundles\index\index.ie.css" [3]: 2ms
01:17:34.617 - info: [*] make 'desktop.bundles\index\index.ie.css' [3]
01:17:34.641 - info: [t] Build time for "desktop.bundles\index\index.ie.css" [3]: 27ms
01:17:34.647 - info: [t] Build time for "desktop.bundles\index\index.css" [3]: 33ms
01:17:34.651 - info: [t] isValid() time for "desktop.bundles\index\_index.css" [3]: 2ms
01:17:34.652 - info: [*] make 'desktop.bundles\index\_index.css' [3]
01:17:34.656 - info: [t] isValid() time for "desktop.bundles\index\_index.ie.css" [3]: 6ms
01:17:34.657 - info: [*] make 'desktop.bundles\index\_index.ie.css' [3]
01:17:35.410 - info: [t] Build time for "desktop.bundles\index\_index.css" [3]:
761ms
01:17:35.482 - info: [t] Build time for "desktop.bundles\index\_index.ie.css" [3]: 832ms
01:17:35.589 - info: [t] Build time for "desktop.bundles\index\index.browser.js+bemhtml" [3]: 975ms
01:17:35.591 - info: [t] isValid() time for "desktop.bundles\index\_index.js" [3]: 1ms
01:17:35.591 - info: [*] make 'desktop.bundles\index\_index.js' [3]
01:17:36.104 - info: [t] Build time for "desktop.bundles\index\_index.js" [3]: 514ms
01:17:36.141 - info: [t] Build time for "desktop.bundles\index\index.bemhtml" [3]: 1527ms
01:17:36.144 - info: [t] isValid() time for "desktop.bundles\index\_index.bemhtml.js" [3]: 2ms
01:17:36.144 - info: [*] make 'desktop.bundles\index\_index.bemhtml.js' [3]
01:17:36.152 - info: [t] isValid() time for "desktop.bundles\index\index.html" [3]: 4ms
01:17:36.152 - info: [*] make 'desktop.bundles\index\index.html' [3]
01:17:36.168 - info: [t] Build time for "desktop.bundles\index\index.html" [3]:
20ms
01:17:36.529 - info: [t] Build time for "desktop.bundles\index\_index.bemhtml.js" [3]: 387ms
01:17:36.531 - info: [t] Build total for "desktop.bundles\index": 3195ms
01:17:36.562 - info: [i] Going to build 'desktop.bundles\index\_index.css' [4]
01:17:36.622 - info: [t] isValid() time for "libs\bem-core" [4]: 59ms
01:17:36.702 - info: [t] isValid() time for "libs\bem-components" [4]: 139ms
01:17:36.859 - info: [i] Going to build 'desktop.bundles\index\_index.js' [5]
01:17:36.895 - info: [t] isValid() time for "libs\bem-core" [5]: 36ms
01:17:36.898 - info: [t] isValid() time for "libs\bem-pr" [4]: 335ms
01:17:36.900 - info: [t] isValid() time for "libs" [4]: 1ms
01:17:36.903 - info: [*] make 'libs' [4]
01:17:36.904 - info: [t] Build time for "libs" [4]: 5ms
01:17:36.951 - info: [t] isValid() time for "libs\bem-components" [5]: 91ms
01:17:36.954 - info: [t] isValid() time for "desktop.bundles\index\index.bemdecl.js" [4]: 2ms
01:17:36.955 - info: [t] isValid() time for "desktop.bundles\index\index.deps.js" [4]: 0ms
01:17:36.956 - info: [*] make 'desktop.bundles\index\index.deps.js' [4]
01:17:37.059 - info: [t] isValid() time for "libs\bem-pr" [5]: 160ms
01:17:37.060 - info: [t] isValid() time for "libs" [5]: 0ms
01:17:37.060 - info: [*] make 'libs' [5]
01:17:37.060 - info: [t] Build time for "libs" [5]: 0ms
01:17:37.105 - info: [t] isValid() time for "desktop.bundles\index\index.bemdecl.js" [5]: 2ms
01:17:37.110 - info: [t] Build time for "desktop.bundles\index\index.deps.js" [4]: 155ms
01:17:37.111 - info: [t] isValid() time for "desktop.bundles\index\index.deps.js" [5]: 0ms
01:17:37.112 - info: [*] make 'desktop.bundles\index\index.deps.js' [5]
01:17:37.112 - info: [t] isValid() time for "desktop.bundles\index\index.css" [4]: 1ms
01:17:37.113 - info: [*] make 'desktop.bundles\index\index.css' [4]
01:17:37.132 - info: [t] Build time for "desktop.bundles\index\index.deps.js" [5]: 21ms
01:17:37.134 - info: [t] isValid() time for "desktop.bundles\index\index.browser.js+bemhtml" [5]: 0ms
01:17:37.134 - info: [*] make 'desktop.bundles\index\index.browser.js+bemhtml' [5]
01:17:37.137 - info: [t] Build time for "desktop.bundles\index\index.css" [4]: 26ms
01:17:37.139 - info: [t] isValid() time for "desktop.bundles\index\_index.css" [4]: 1ms
01:17:37.140 - info: [t] Build total for "desktop.bundles\index\_index.css": 581ms
01:17:37.679 - info: [t] Build time for "desktop.bundles\index\index.browser.js+bemhtml" [5]: 546ms
01:17:37.680 - info: [t] isValid() time for "desktop.bundles\index\_index.js" [5]: 0ms
01:17:37.681 - info: [t] Build total for "desktop.bundles\index\_index.js": 823ms

@ilyar
Copy link
Contributor Author

ilyar commented Mar 21, 2014

@tadatuta

заранее скажу, что я не готов вливать переименование desktop.bundles -> bundles, т.к. хочется, чтобы было консистентно с другими проектами, где мы используем разделение по платформам.

согласен, вернул

можешь разбить их на отдельные смысловые куски? так и обсуждать проще и вливать.
размышления о том, как быть с конфигом уровней есть тут: bem/bem-components#320

хорошо, прочитаю размышления и разобью на куски с учетом #38

@ilyar
Copy link
Contributor Author

ilyar commented Mar 21, 2014

@tadatuta скажи возможно не включая bem-pr избавиться от варнингов? Мотивация: когда знакомишься с новым и что то не получается начинаешь смотреть на варнинги, а когда понимаешь что они тут ни причем и относятся к используемой в проекте библиотеке становится грустно, так вот что бы не было грустно.

@tadatuta
Copy link
Member

@ilyar завел про это bem/bem-components#336

@ilyar ilyar mentioned this pull request Mar 22, 2014
@ilyar
Copy link
Contributor Author

ilyar commented Mar 22, 2014

убрал bem-pr, подождем решение с варнингами в bem/bem-components#336

обновил только настройку уровней но она не будет работать без #41
настройку сборки оставил за #38

// cc @tadatuta


PRJ_ROOT = environ.PRJ_ROOT,
PRJ_TECHS = join(PRJ_ROOT, '.bem/techs'),
PRJ_TECHS = PATH.resolve(__dirname, '../techs/'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

чем этот вариант лучше, чем было (PRJ_ROOT = environ.PRJ_ROOT)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

соглашусь, лучше PRJ_ROOT = environ.PRJ_ROOT

tadatuta added a commit that referenced this pull request Apr 6, 2014
@tadatuta tadatuta merged commit 54e3e47 into bem:bem-core Apr 6, 2014
@ilyar ilyar deleted the fix/bem-core/update_configure_project branch April 6, 2014 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants