You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I may tackle this one, but want to raise here first.
I think it would be worth converting snapshots map[snapshotID]*snapshot to use sync.Map, or perhaps just use a mutex to protect it. Wondering if there is a preference for minimum golang version that should be targeted, since sync.Map was introduced in golang 1.9. Thoughts?
For context, my use case is a set of tests that assert snapshots from multiple concurrent goroutines. As written, it hits the error: fatal error: concurrent map writes while updating snapshots on github.com/beme/abide/abide.go:230.
The text was updated successfully, but these errors were encountered:
I may tackle this one, but want to raise here first.
I think it would be worth converting
snapshots map[snapshotID]*snapshot
to usesync.Map
, or perhaps just use a mutex to protect it. Wondering if there is a preference for minimum golang version that should be targeted, since sync.Map was introduced in golang 1.9. Thoughts?For context, my use case is a set of tests that assert snapshots from multiple concurrent goroutines. As written, it hits the error:
fatal error: concurrent map writes
while updating snapshots ongithub.com/beme/abide/abide.go:230
.The text was updated successfully, but these errors were encountered: