Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

.state should reflect compiled tags #86

Closed
bemson opened this Issue Feb 20, 2014 · 5 comments

Comments

Projects
None yet
1 participant
Owner

bemson commented Feb 20, 2014

The .state property should reflect as many compiled tags as possible. This information could be useful within callback logic.

Below lists the tags which should be reflected in the .state member. Commits/Comments will address how to name and set these - a one to one match isn't always sensible, and the value could be a summary (e.g., a boolean).

Not all of these tags need to be reflected in the .state property. This ticket will hash out the details.

@bemson bemson added this to the Polish milestone Feb 20, 2014

@bemson bemson self-assigned this Feb 20, 2014

@bemson bemson added the Proxy label Feb 20, 2014

Owner

bemson commented Feb 21, 2014

_wait -> state.delays (boolean)

_wait is already reflected as the boolean state.delays. The unit tests need to be updated to verify this feature.

Owner

bemson commented Feb 21, 2014

_next -> state.fwds (boolean)

Valid _next queries are reflected as a boolean .state.fwds member - as in "forwards to another state". The abbreviation isn't great, but it provides minimal information to external routines.

Only the "on" callback would then be able to observe where the instance is forwarded to. I don't think the forward target is important as knowing that hitting a given state forwards to another state.

Owner

bemson commented Feb 21, 2014

nixing _conceal

While exposing _conceal as a boolean state.hidden member seems complete, I'm not sure of it's value.

That is, once Salt is in a concealed/hidden branch, it's no longer concealed, and the property does not matter. Until Salt allows inspecting other states besides the current one, sharing this information isn't exactly useful as much as it's informative...

Nixing for now.

Owner

bemson commented Feb 21, 2014

_tail -> state.tails (boolean)

Valid _tail queries are reflected as a boolean .state.tails member. This is simple enough.

Owner

bemson commented Feb 21, 2014

nixing _capture

The _captures tag is too comprehensive to reflect in a property, without exposing the compiled (i.e., hard to interpret) data structure that identifies capture/filter criteria. I think it's useful information, but this one just ain't gonna happen right now.

@bemson bemson removed the Figuring Out label Feb 21, 2014

@bemson bemson closed this in c6cf1f5 Feb 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment